Skip to content

Restore AllEmojiGlyphs for ports using Skia #47350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2025
Merged

Restore AllEmojiGlyphs for ports using Skia #47350

merged 1 commit into from
Jun 29, 2025
+11 −0

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Jun 29, 2025 •
edited by webkit-early-warning-system
Loading

b2ed74d

Restore AllEmojiGlyphs for ports using Skia
https://bugs.webkit.org/show_bug.cgi?id=295172

Unreviewed.

In 296769@main I removed AllEmojiGlyphs not realizing that 296713@main
took a dependency upon it. So restore it selectively.

Canonical link: https://commits.webkit.org/296778@main

81f5528

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk self-assigned this Jun 29, 2025
@annevk annevk added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jun 29, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 29, 2025 •
edited
Loading

EWS run on current version of this PR (hash 81f5528)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk mentioned this pull request Jun 29, 2025
Merged
@annevk
Copy link
Contributor Author

annevk commented Jun 29, 2025

@rkirsling @carlosgcampos FYI. I plan to land this once Linux/Windows is green. Feel free to land sooner if you're feeling lucky.

@annevk annevk added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 29, 2025
@annevk
Restore AllEmojiGlyphs for ports using Skia
b2ed74d 
https://bugs.webkit.org/show_bug.cgi?id=295172

Unreviewed.

In 296769@main I removed AllEmojiGlyphs not realizing that 296713@main
took a dependency upon it. So restore it selectively.

Canonical link: https://commits.webkit.org/296778@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Restore-AllEmojiGlyphs-for-ports-using-Skia branch from 81f5528 to b2ed74d Compare June 29, 2025 08:36
@webkit-commit-queue
Copy link
Collaborator

Committed 296778@main (b2ed74d): https://commits.webkit.org/296778@main

Reviewed commits have been landed. Closing PR #47350 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b2ed74d into WebKit:main Jun 29, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 29, 2025
@annevk annevk deleted the eng/Restore-AllEmojiGlyphs-for-ports-using-Skia branch June 29, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@annevk annevk

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annevk @webkit-early-warning-system @webkit-commit-queue