Reduce use of pointer arithmetic in TinyPtrSet and BitVector #47334
+7
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash e18a10b) |
🧪 bindings
darinadler
approved these changes
Jun 28, 2025
Comment on lines
+473
to
+474
| std::span<const uint8_t> byteSpan() const LIFETIME_BOUND { return unsafeMakeSpan(reinterpret_cast<const uint8_t*>(m_words), byteCount(numBits())); } | ||
| std::span<uint8_t> byteSpan() LIFETIME_BOUND { return unsafeMakeSpan(reinterpret_cast<uint8_t*>(m_words), byteCount(numBits())); } |
There was a problem hiding this comment.
The old code used bit casts and this uses reinterpret casts. Is there a reason to choose one over the other?
There was a problem hiding this comment.
The code I removed was using bit_cast whereas the code I'm updating was using reinterpret_cast and still is. I did not purposely change the way of casting. I can probably use std::bit_cast here since we're casting to bytes.
There was a problem hiding this comment.
Actually using std::bit_cast doesn't build here.
https://bugs.webkit.org/show_bug.cgi?id=295141 Reviewed by Darin Adler. Reduce use of pointer arithmetic in TinyPtrSet and BitVector by leveraging flexible array members instead. * Source/WTF/wtf/BitVector.h: * Source/WTF/wtf/TinyPtrSet.h: (WTF::TinyPtrSet::OutOfLineList::list): Canonical link: https://commits.webkit.org/296776@main
e18a10b to
fbcfad4
Compare
|
Committed 296776@main (fbcfad4): https://commits.webkit.org/296776@main Reviewed commits have been landed. Closing PR #47334 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fbcfad4
e18a10b