Skip to content

[WebAuthn] Pass override credentials in as optional parameter #47326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

[WebAuthn] Pass override credentials in as optional parameter #47326

merged 1 commit into from
Jun 30, 2025
+3 −3

Conversation

pascoej
Copy link
Member

@pascoej pascoej commented Jun 28, 2025 •
edited by webkit-early-warning-system
Loading

fb8ec98

[WebAuthn] Pass override credentials in as optional parameter
rdar://154511868
https://bugs.webkit.org/show_bug.cgi?id=295131

Reviewed by Charlie Wolfe.

In https://bugs.webkit.org/show_bug.cgi?id=293805, we started passing the override{Allow,Exclude}Credentials
parameter a Vector, when we should've passed std:nullopt for the empty allow / exclude list.

This patch fixes that.

* Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::CtapAuthenticator::continueMakeCredentialAfterCheckExcludedCredentials):
(WebKit::CtapAuthenticator::continueGetAssertionAfterCheckAllowCredentials):

Canonical link: https://commits.webkit.org/296817@main

38385f4

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pascoej pascoej self-assigned this Jun 28, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 28, 2025 •
edited
Loading

EWS run on current version of this PR (hash 38385f4)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 28, 2025
@pascoej pascoej marked this pull request as ready for review June 28, 2025 02:55
@pascoej pascoej requested a review from cdumez as a code owner June 28, 2025 02:55
@pascoej pascoej requested a review from brentfulgham June 30, 2025 16:32
@pascoej pascoej added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged merge-queue Applied to send a pull request to merge-queue labels Jun 30, 2025
@pascoej
[WebAuthn] Pass override credentials in as optional parameter
fb8ec98 
rdar://154511868
https://bugs.webkit.org/show_bug.cgi?id=295131

Reviewed by Charlie Wolfe.

In https://bugs.webkit.org/show_bug.cgi?id=293805, we started passing the override{Allow,Exclude}Credentials
parameter a Vector, when we should've passed std:nullopt for the empty allow / exclude list.

This patch fixes that.

* Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::CtapAuthenticator::continueMakeCredentialAfterCheckExcludedCredentials):
(WebKit::CtapAuthenticator::continueGetAssertionAfterCheckAllowCredentials):

Canonical link: https://commits.webkit.org/296817@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebAuthn-Pass-override-credentials-in-as-optional-parameter branch from 38385f4 to fb8ec98 Compare June 30, 2025 19:12
@webkit-commit-queue
Copy link
Collaborator

Committed 296817@main (fb8ec98): https://commits.webkit.org/296817@main

Reviewed commits have been landed. Closing PR #47326 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit fb8ec98 into WebKit:main Jun 30, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliewolfe charliewolfe charliewolfe approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@brentfulgham brentfulgham Awaiting requested review from brentfulgham

Assignees

@pascoej pascoej

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pascoej @webkit-early-warning-system @webkit-commit-queue @charliewolfe @webkit-ews-buildbot