Skip to content

REGRESSION(294902@main): shape-margin and vertical-align do not report the correct computed values when zoomed #47325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

REGRESSION(294902@main): shape-margin and vertical-align do not report the correct computed values when zoomed #47325

merged 1 commit into from
Jun 28, 2025
+95 −58

Conversation

weinig
Copy link
Contributor

@weinig weinig commented Jun 27, 2025 •
edited by webkit-early-warning-system
Loading

7eeb199

REGRESSION(294902@main): shape-margin and vertical-align do not report the correct computed values when zoomed
https://bugs.webkit.org/show_bug.cgi?id=295128

Reviewed by Darin Adler.

Fix regression where zoom was not taken into account for 'shape-margin' and 'vertical-align'
computed values.

* LayoutTests/fast/css/zoom-shape-margin-expected.txt: Added.
* LayoutTests/fast/css/zoom-shape-margin.html: Added.
* LayoutTests/fast/css/zoom-vertical-align-expected.txt: Added.
* LayoutTests/fast/css/zoom-vertical-align.html: Added.
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/style/StyleExtractorConverter.h:
(WebCore::Style::ExtractorConverter::convertLengthWithoutApplyingZoom): Deleted.
* Source/WebCore/style/StyleExtractorCustom.h:
(WebCore::Style::ExtractorCustom::extractVerticalAlign):
(WebCore::Style::ExtractorCustom::extractVerticalAlignSerialization):
* Source/WebCore/style/StyleExtractorSerializer.h:
(WebCore::Style::ExtractorSerializer::serializeLengthWithoutApplyingZoom): Deleted.

Canonical link: https://commits.webkit.org/296767@main

63496ba

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@weinig weinig self-assigned this Jun 27, 2025
@weinig weinig added the CSS Cascading Style Sheets implementation label Jun 27, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 27, 2025 •
edited
Loading

EWS run on current version of this PR (hash 63496ba)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@weinig weinig requested review from darinadler, smfr and anttijk June 27, 2025 23:17
@darinadler
Copy link
Member

@nt1m would want me to remind you to upstream WPT changes, but I know you don’t really need a reminder.

@weinig weinig added the merge-queue Applied to send a pull request to merge-queue label Jun 28, 2025
@weinig
REGRESSION(294902@main): shape-margin and vertical-align do not repor…
7eeb199 
…t the correct computed values when zoomed

https://bugs.webkit.org/show_bug.cgi?id=295128

Reviewed by Darin Adler.

Fix regression where zoom was not taken into account for 'shape-margin' and 'vertical-align'
computed values.

* LayoutTests/fast/css/zoom-shape-margin-expected.txt: Added.
* LayoutTests/fast/css/zoom-shape-margin.html: Added.
* LayoutTests/fast/css/zoom-vertical-align-expected.txt: Added.
* LayoutTests/fast/css/zoom-vertical-align.html: Added.
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/style/StyleExtractorConverter.h:
(WebCore::Style::ExtractorConverter::convertLengthWithoutApplyingZoom): Deleted.
* Source/WebCore/style/StyleExtractorCustom.h:
(WebCore::Style::ExtractorCustom::extractVerticalAlign):
(WebCore::Style::ExtractorCustom::extractVerticalAlignSerialization):
* Source/WebCore/style/StyleExtractorSerializer.h:
(WebCore::Style::ExtractorSerializer::serializeLengthWithoutApplyingZoom): Deleted.

Canonical link: https://commits.webkit.org/296767@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-294902-main-shape-margin-and-vertical-align-do-not-report-the-correct-computed-values-when-zoomed branch from 63496ba to 7eeb199 Compare June 28, 2025 03:35
@webkit-commit-queue
Copy link
Collaborator

Committed 296767@main (7eeb199): https://commits.webkit.org/296767@main

Reviewed commits have been landed. Closing PR #47325 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7eeb199 into WebKit:main Jun 28, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@smfr smfr Awaiting requested review from smfr

@anttijk anttijk Awaiting requested review from anttijk

Assignees

@weinig weinig

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weinig @webkit-early-warning-system @darinadler @webkit-commit-queue