Adopt smart pointers in RemoteWebInspectorUI.cpp #47322

jelee53 · 2025-06-27T22:04:59Z

`723cfc8`

Adopt smart pointers in RemoteWebInspectorUI.cpp
https://bugs.webkit.org/show_bug.cgi?id=295068
rdar://problem/154521813

Reviewed by NOBODY (OOPS!).

Smart pointer adoption as per the static analyzer.

* Source/WebCore/page/Page.cpp:
(WebCore::Page::checkedDiagnosticLoggingClient const):
* Source/WebCore/page/Page.h:
* Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp:
(WebKit::RemoteWebInspectorUI::RemoteWebInspectorUI):
(WebKit::RemoteWebInspectorUI::initialize):
(WebKit::RemoteWebInspectorUI::sendMessageToBackend):
(WebKit::RemoteWebInspectorUI::windowObjectCleared):
(WebKit::RemoteWebInspectorUI::frontendLoaded):
(WebKit::RemoteWebInspectorUI::changeSheetRect):
(WebKit::RemoteWebInspectorUI::setForcedAppearance):
(WebKit::RemoteWebInspectorUI::startWindowDrag):
(WebKit::RemoteWebInspectorUI::bringToFront):
(WebKit::RemoteWebInspectorUI::closeWindow):
(WebKit::RemoteWebInspectorUI::reopen):
(WebKit::RemoteWebInspectorUI::resetState):
(WebKit::RemoteWebInspectorUI::openURLExternally):
(WebKit::RemoteWebInspectorUI::revealFileExternally):
(WebKit::RemoteWebInspectorUI::save):
(WebKit::RemoteWebInspectorUI::load):
(WebKit::RemoteWebInspectorUI::pickColorFromScreen):
(WebKit::RemoteWebInspectorUI::showCertificate):
(WebKit::RemoteWebInspectorUI::setInspectorPageDeveloperExtrasEnabled):
(WebKit::RemoteWebInspectorUI::logDiagnosticEvent):
(WebKit::RemoteWebInspectorUI::protectedWebPage):
* Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h:

723cfc8

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-06-27T22:05:08Z

EWS run on previous version of this PR (hash 0e47b0a)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	⏳ 🧪 win-tests
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	⏳ 🛠 playstation
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

pvollan · 2025-06-27T22:16:04Z

Source/WebCore/page/Page.cpp

@@ -1591,6 +1591,11 @@ DiagnosticLoggingClient& Page::diagnosticLoggingClient() const
    return *m_diagnosticLoggingClient;
 }

+CheckedRef<DiagnosticLoggingClient> Page::protectedDiagnosticLoggingClient() const


I think we can call this member function 'checkedDiagnosticLoggingClient()'

pvollan · 2025-06-27T22:22:52Z

Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp

@@ -72,7 +72,7 @@ void RemoteWebInspectorUI::initialize(DebuggableInfoData&& debuggableInfo, const
    m_debuggableInfo = WTFMove(debuggableInfo);
    m_backendCommandsURL = backendCommandsURL;

-    m_page->protectedCorePage()->inspectorController().setInspectorFrontendClient(this);
+    WeakRef { m_page }->protectedCorePage()->inspectorController().setInspectorFrontendClient(this);


Perhaps we can create a helper method: Ref<WebPage> RemoteWebInspectorUI::protectedWebPage()?

webkit-early-warning-system · 2025-06-27T23:04:06Z

EWS run on previous version of this PR (hash 6bc4dc3)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	⏳ 🧪 win-tests
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

pvollan · 2025-06-27T23:13:36Z

Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp


-    m_frontendHost = InspectorFrontendHost::create(this, m_page->protectedCorePage().get());
-    m_frontendHost->addSelfToGlobalObjectInWorld(mainThreadNormalWorldSingleton());
+    frontendHost = InspectorFrontendHost::create(this, protectedWebPage()->protectedCorePage().get());


We should still assign this to m_frontendHost.

Ugh that's so careless of me! Fixing.

webkit-ews-buildbot · 2025-06-27T23:28:45Z

Safer C++ Build #41906 (`0e47b0a`)

❌ Found 1 failing file with 4 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-early-warning-system · 2025-06-27T23:48:21Z

EWS run on previous version of this PR (hash b4952c5)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-06-28T00:54:49Z

EWS run on previous version of this PR (hash 5c7ff4c)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	⏳ 🧪 win-tests
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~	~~🛠 playstation~~
	⏳ 🛠 tv	~~🛠 mac-safer-cpp~~	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim		⏳ 🧪 jsc-armv7-tests
	⏳ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-06-28T01:06:33Z

EWS run on previous version of this PR (hash 5ba16b5)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
❌ 🛠 🧪 unsafe-merge	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

rniwa · 2025-06-28T01:12:46Z

Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp

@@ -90,16 +90,16 @@ void RemoteWebInspectorUI::sendMessageToFrontend(const String& message)

 void RemoteWebInspectorUI::sendMessageToBackend(const String& message)
 {
-    WebProcess::singleton().parentProcessConnection()->send(Messages::RemoteWebInspectorUIProxy::SendMessageToBackend(message), m_page->identifier());
+    WebProcess::singleton().protectedParentProcessConnection()->send(Messages::RemoteWebInspectorUIProxy::SendMessageToBackend(message), m_page->identifier());


This is a bit silly. parentProcessConnection is a singleton just like WebProcess::singleton(). Maybe we can wrap in a helper function by the name of parentProcessConnectionSingleton().

I see. There's a lot of usages of protectedParentProcessConnection() outside of this file. Should I file a bugzilla ticket to replace all of those?

Talked offline. We will be leaving this as-is.

webkit-ews-buildbot · 2025-06-28T01:17:05Z

Safer C++ Build #41918 (`b4952c5`)

❌ Found 1 failing file with 4 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-commit-queue · 2025-06-30T21:01:12Z

Commit message contains (OOPS!), blocking PR #47322. Details: Build #17705

webkit-early-warning-system · 2025-06-30T22:25:42Z

EWS run on previous version of this PR (hash 47adbd8)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

cdumez · 2025-07-01T04:24:00Z

Source/WebKit/UIProcess/Cocoa/DiagnosticLoggingClient.h

@@ -35,8 +35,9 @@

 namespace WebKit {

-class DiagnosticLoggingClient final : public API::DiagnosticLoggingClient {
+class DiagnosticLoggingClient final : public API::DiagnosticLoggingClient, public CanMakeCheckedPtr<DiagnosticLoggingClient> {


Can you explain this change? Where is this used in this PR? I looked at the PR twice but couldn't see any code using a CheckedPtr to a WebKit::DiagnosticLoggingClient, only to the WebCore one.

I needed DiagnosticLoggingClient to become a CheckedPtr in order to make this helper function:

Source/WebCore/page/Page.h: WEBCORE_EXPORT CheckedRef<DiagnosticLoggingClient> checkedDiagnosticLoggingClient() const;`

which I eventually used in

Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp: void RemoteWebInspectorUI::logDiagnosticEvent(const String& eventName, const DiagnosticLoggingClient::ValueDictionary& dictionary) { .. protectedWebPage()->protectedCorePage()->checkedDiagnosticLoggingClient()->logDiagnosticMessageWithValueDictionary(eventName, "Remote Web Inspector Frontend Diagnostics"_s, dictionary, ShouldSample::No); }

Also, we will need checkedDiagnosticLoggingClient() to fix other unsafe cpp errors as well, such as with WebResourceLoader.cpp and WebInspectorUI.cpp:

Chris is pointing out that we have both Source/WebCore/page/DiagnosticLoggingClient.h and Source/WebKit/UIProcess/Cocoa/DiagnosticLoggingClient.h. And that you're not using the latter in this patch. And the former already has CanMakeCheckedPtr.

Ohhh, I didn't even realize that there were two separate DiagnosticLoggingClient headers... Now that I'm reading Chris's comment closer - he's talking about a Webcore vs a Webkit one.

Anyways, even I was using the wrong file, I should have double-checked if the parent class was ref'd or check'd.

You two are right. I don't need this change at all since I'm using the Webcore one not the Webkit. I'll back this out.

cdumez · 2025-07-01T04:24:25Z

Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h


-    WeakRef<WebPage> m_page;
+    const WeakRef<WebPage> m_page;


Why this change?

Oops. Don't need it as we discussed. I forgot about this and will back it out.

cdumez · 2025-07-01T04:25:11Z

Adopt smart pointers in RemoteWebInspectorUI.cpp
https://bugs.webkit.org/show_bug.cgi?id=295068
Include a Radar link (OOPS!).

You need to drop this OOPS line.

https://bugs.webkit.org/show_bug.cgi?id=295068 rdar://problem/154521813 Reviewed by NOBODY (OOPS!). Smart pointer adoption as per the static analyzer. * Source/WebCore/page/Page.cpp: (WebCore::Page::checkedDiagnosticLoggingClient const): * Source/WebCore/page/Page.h: * Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations: * Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: * Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp: (WebKit::RemoteWebInspectorUI::RemoteWebInspectorUI): (WebKit::RemoteWebInspectorUI::initialize): (WebKit::RemoteWebInspectorUI::sendMessageToBackend): (WebKit::RemoteWebInspectorUI::windowObjectCleared): (WebKit::RemoteWebInspectorUI::frontendLoaded): (WebKit::RemoteWebInspectorUI::changeSheetRect): (WebKit::RemoteWebInspectorUI::setForcedAppearance): (WebKit::RemoteWebInspectorUI::startWindowDrag): (WebKit::RemoteWebInspectorUI::bringToFront): (WebKit::RemoteWebInspectorUI::closeWindow): (WebKit::RemoteWebInspectorUI::reopen): (WebKit::RemoteWebInspectorUI::resetState): (WebKit::RemoteWebInspectorUI::openURLExternally): (WebKit::RemoteWebInspectorUI::revealFileExternally): (WebKit::RemoteWebInspectorUI::save): (WebKit::RemoteWebInspectorUI::load): (WebKit::RemoteWebInspectorUI::pickColorFromScreen): (WebKit::RemoteWebInspectorUI::showCertificate): (WebKit::RemoteWebInspectorUI::setInspectorPageDeveloperExtrasEnabled): (WebKit::RemoteWebInspectorUI::logDiagnosticEvent): (WebKit::RemoteWebInspectorUI::protectedWebPage): * Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h:

webkit-early-warning-system · 2025-07-01T08:14:29Z

EWS run on current version of this PR (hash 723cfc8)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

jelee53 requested review from dcrousso, patrickangle and cdumez as code owners June 27, 2025 22:05

jelee53 self-assigned this Jun 27, 2025

jelee53 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jun 27, 2025

jelee53 requested review from pvollan, annevk and rniwa June 27, 2025 22:05

pvollan reviewed Jun 27, 2025

View reviewed changes

jelee53 force-pushed the eng/Adopt-smart-pointers-in-RemoteWebInspectorUI-cpp branch from 0e47b0a to 6bc4dc3 Compare June 27, 2025 23:04

pvollan reviewed Jun 27, 2025

View reviewed changes

jelee53 force-pushed the eng/Adopt-smart-pointers-in-RemoteWebInspectorUI-cpp branch from 6bc4dc3 to b4952c5 Compare June 27, 2025 23:48

jelee53 force-pushed the eng/Adopt-smart-pointers-in-RemoteWebInspectorUI-cpp branch from b4952c5 to 5c7ff4c Compare June 28, 2025 00:54

jelee53 force-pushed the eng/Adopt-smart-pointers-in-RemoteWebInspectorUI-cpp branch from 5c7ff4c to 5ba16b5 Compare June 28, 2025 01:06

rniwa reviewed Jun 28, 2025

View reviewed changes

rniwa approved these changes Jun 30, 2025

View reviewed changes

pvollan approved these changes Jun 30, 2025

View reviewed changes

pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 30, 2025

webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jun 30, 2025

jelee53 force-pushed the eng/Adopt-smart-pointers-in-RemoteWebInspectorUI-cpp branch from 5ba16b5 to 47adbd8 Compare June 30, 2025 22:25

cdumez reviewed Jul 1, 2025

View reviewed changes

jelee53 removed the merging-blocked Applied to prevent a change from being merged label Jul 1, 2025

jelee53 force-pushed the eng/Adopt-smart-pointers-in-RemoteWebInspectorUI-cpp branch from 47adbd8 to 723cfc8 Compare July 1, 2025 08:14

Adopt smart pointers in RemoteWebInspectorUI.cpp #47322

Are you sure you want to change the base?

Adopt smart pointers in RemoteWebInspectorUI.cpp #47322

Conversation

jelee53 commented Jun 27, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-ews-buildbot commented Jun 27, 2025

Safer C++ Build #41906 (0e47b0a)

Uh oh!

webkit-early-warning-system commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-ews-buildbot commented Jun 28, 2025

Safer C++ Build #41918 (b4952c5)

Uh oh!

webkit-commit-queue commented Jun 30, 2025

Uh oh!

webkit-early-warning-system commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelee53 Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelee53 Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cdumez commented Jul 1, 2025

Uh oh!

webkit-early-warning-system commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jelee53 commented Jun 27, 2025 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Jun 27, 2025 •

edited

Loading

webkit-early-warning-system commented Jun 27, 2025 •

edited

Loading

Safer C++ Build #41906 (`0e47b0a`)

webkit-early-warning-system commented Jun 27, 2025 •

edited

Loading

webkit-early-warning-system commented Jun 28, 2025 •

edited

Loading

webkit-early-warning-system commented Jun 28, 2025 •

edited

Loading

Safer C++ Build #41918 (`b4952c5`)

webkit-early-warning-system commented Jun 30, 2025 •

edited

Loading

jelee53 Jul 1, 2025 •

edited

Loading

jelee53 Jul 1, 2025 •

edited

Loading

webkit-early-warning-system commented Jul 1, 2025 •

edited

Loading