Skip to content

REGRESSION(296741@main): Broke the HAVE(DIGITAL_CREDENTIALS_UI) build #47321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

REGRESSION(296741@main): Broke the HAVE(DIGITAL_CREDENTIALS_UI) build #47321

merged 1 commit into from
Jun 27, 2025

Conversation

aprotyas
Copy link
Member

@aprotyas aprotyas commented Jun 27, 2025 •
edited by webkit-early-warning-system
Loading

655ed8a

REGRESSION(296741@main): Broke the HAVE(DIGITAL_CREDENTIALS_UI) build
https://bugs.webkit.org/show_bug.cgi?id=295126
rdar://154520831

Unreviewed build fix.

RetainPtr<> could not deduce the NSString template argument, so we make
it explicit.

* Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.mm:
(-[WKDigitalCredentialsPicker handlePresentmentCompletionWithResponse:error:]):

Canonical link: https://commits.webkit.org/296753@main

9b6dcf0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@aprotyas aprotyas requested a review from cdumez as a code owner June 27, 2025 21:45
@aprotyas aprotyas self-assigned this Jun 27, 2025
@aprotyas aprotyas added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 27, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 27, 2025 •
edited
Loading

EWS run on current version of this PR (hash 9b6dcf0)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@aprotyas aprotyas added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 27, 2025
@aprotyas
REGRESSION(296741@main): Broke the HAVE(DIGITAL_CREDENTIALS_UI) build
655ed8a 
https://bugs.webkit.org/show_bug.cgi?id=295126
rdar://154520831

Unreviewed build fix.

RetainPtr<> could not deduce the NSString template argument, so we make
it explicit.

* Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.mm:
(-[WKDigitalCredentialsPicker handlePresentmentCompletionWithResponse:error:]):

Canonical link: https://commits.webkit.org/296753@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296753@main (655ed8a): https://commits.webkit.org/296753@main

Reviewed commits have been landed. Closing PR #47321 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 655ed8a into WebKit:main Jun 27, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 27, 2025
@aprotyas aprotyas deleted the eng/295126 branch June 27, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@aprotyas aprotyas

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aprotyas @webkit-early-warning-system @webkit-commit-queue