Skip to content

Add new email address for Michael Saboff #47316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

Add new email address for Michael Saboff #47316

merged 1 commit into from
Jun 28, 2025
+2 −0

Conversation

msaboff
Copy link
Contributor

@msaboff msaboff commented Jun 27, 2025 •
edited by webkit-early-warning-system
Loading

bb174c3

Add new email address for Michael Saboff
https://bugs.webkit.org/show_bug.cgi?id=295122

Reviewed by Yusuke Suzuki and Tim Nguyen.

Added new email addresses for Michael Saboff

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/296774@main

9b0a8c3

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe loading 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 loading 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@msaboff msaboff requested a review from JonWBedard as a code owner June 27, 2025 20:20
@msaboff msaboff self-assigned this Jun 27, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 27, 2025 •
edited
Loading

EWS run on previous version of this PR (hash e4f64e8)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@msaboff msaboff added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jun 27, 2025
Constellation
Constellation reviewed Jun 28, 2025
View reviewed changes
metadata/contributors.json Outdated
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you need to remove this part's change.

Copy link
Contributor Author

@msaboff msaboff Jun 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran validate-committer-lists --canonicalize to fix the issue.

Uploaded new PR.

@msaboff msaboff force-pushed the eng/Add-new-email-address-for-Michael-Saboff branch from e4f64e8 to 9b0a8c3 Compare June 28, 2025 14:15
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 28, 2025 •
edited
Loading

EWS run on current version of this PR (hash 9b0a8c3)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe loading 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 loading 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@msaboff msaboff added the merge-queue Applied to send a pull request to merge-queue label Jun 28, 2025
@msaboff
Add new email address for Michael Saboff
bb174c3 
https://bugs.webkit.org/show_bug.cgi?id=295122

Reviewed by Yusuke Suzuki and Tim Nguyen.

Added new email addresses for Michael Saboff

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/296774@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-new-email-address-for-Michael-Saboff branch from 9b0a8c3 to bb174c3 Compare June 28, 2025 22:20
@webkit-commit-queue
Copy link
Collaborator

Committed 296774@main (bb174c3): https://commits.webkit.org/296774@main

Reviewed commits have been landed. Closing PR #47316 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit bb174c3 into WebKit:main Jun 28, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

@nt1m nt1m nt1m approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@msaboff msaboff

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msaboff @webkit-early-warning-system @webkit-commit-queue @Constellation @nt1m