Skip to content

REGRESSION (290607@main): guichet.public.lu: Broken layout where 'Display All' is hidden behind summary list items #47309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

REGRESSION (290607@main): guichet.public.lu: Broken layout where 'Display All' is hidden behind summary list items #47309

merged 1 commit into from
Jun 27, 2025
+30 −1

Conversation

weinig
Copy link
Contributor

@weinig weinig commented Jun 27, 2025 •
edited by webkit-early-warning-system
Loading

b49fecc

REGRESSION (290607@main): guichet.public.lu: Broken layout where 'Display All' is hidden behind summary list items
https://bugs.webkit.org/show_bug.cgi?id=295053

Reviewed by Darin Adler.

In 290607@main, the `float` property was accidentally marked as "inherited".
This fixes that and adds standard inheritance tests.

* LayoutTests/imported/w3c/web-platform-tests/css/CSS2/floats/inheritance-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/CSS2/floats/inheritance.html: Added.
* Source/WebCore/css/CSSProperties.json:

Canonical link: https://commits.webkit.org/296742@main

4e7eb7e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@weinig weinig self-assigned this Jun 27, 2025
@weinig weinig added the CSS Cascading Style Sheets implementation label Jun 27, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 27, 2025 •
edited
Loading

EWS run on current version of this PR (hash 4e7eb7e)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@weinig weinig requested a review from smfr June 27, 2025 18:31
@darinadler
Copy link
Member

I know @smfr should review this, but really it seems clearly correct!

@darinadler darinadler added the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2025
@weinig @darinadler
REGRESSION (290607@main): guichet.public.lu: Broken layout where 'Dis…
b49fecc 
…play All' is hidden behind summary list items

https://bugs.webkit.org/show_bug.cgi?id=295053

Reviewed by Darin Adler.

In 290607@main, the `float` property was accidentally marked as "inherited".
This fixes that and adds standard inheritance tests.

* LayoutTests/imported/w3c/web-platform-tests/css/CSS2/floats/inheritance-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/CSS2/floats/inheritance.html: Added.
* Source/WebCore/css/CSSProperties.json:

Canonical link: https://commits.webkit.org/296742@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-290607-main-guichet-public-lu-Broken-layout-where-Display-All-is-hidden-behind-summary-list-items branch from 4e7eb7e to b49fecc Compare June 27, 2025 19:10
@webkit-commit-queue
Copy link
Collaborator

Committed 296742@main (b49fecc): https://commits.webkit.org/296742@main

Reviewed commits have been landed. Closing PR #47309 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b49fecc into WebKit:main Jun 27, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2025
@nt1m
Copy link
Member

nt1m commented Jun 27, 2025

Looks good, can you export the new WPT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@smfr smfr Awaiting requested review from smfr

Assignees

@weinig weinig

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weinig @webkit-early-warning-system @darinadler @webkit-commit-queue @nt1m