Skip to content

Take view stability into account when updating Overlay Regions #47298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Take view stability into account when updating Overlay Regions #47298

merged 1 commit into from
Jun 30, 2025
+6 −6

Conversation

etiennesegonzac
Copy link
Contributor

@etiennesegonzac etiennesegonzac commented Jun 27, 2025 •
edited by webkit-early-warning-system
Loading

7ebf83c

Take view stability into account when updating Overlay Regions
https://bugs.webkit.org/show_bug.cgi?id=295100
<rdar://153757448>

Reviewed by Simon Fraser.

Pass along a boolean `stable` flag to the `_updateOverlayRegionRects`
method.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(configureScrollViewWithOverlayRegionsIDs):
Use `_isInStableState` to get the scrollview stability.
(-[WKWebView _updateOverlayRegions:destroyedLayers:]):
Pass the boolean down.
(-[WKWebView _updateOverlayRegionsForCustomContentView]):
Always assume we're stable here.
* Source/WebKit/UIProcess/ios/WKBaseScrollView.h:
* Source/WebKit/UIProcess/ios/WKBaseScrollView.mm:
(-[WKBaseScrollView _updateOverlayRegionRects:whileStable:]):
(-[WKBaseScrollView _updateOverlayRegionRects:]): Deleted.
Update the stub.

Canonical link: https://commits.webkit.org/296792@main

28fa37b

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
  🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 win
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
  🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@etiennesegonzac etiennesegonzac requested a review from cdumez as a code owner June 27, 2025 14:44
@etiennesegonzac etiennesegonzac self-assigned this Jun 27, 2025
@etiennesegonzac etiennesegonzac added the Scrolling Bugs related to main thread and off-main thread scrolling label Jun 27, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 27, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 0d25bf5)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
❌ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@etiennesegonzac etiennesegonzac added the merge-queue Applied to send a pull request to merge-queue label Jun 30, 2025
@webkit-commit-queue
Copy link
Collaborator

Commit message contains (OOPS!), blocking PR #47298. Details: Build #23465

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Jun 30, 2025
@etiennesegonzac etiennesegonzac removed the merging-blocked Applied to prevent a change from being merged label Jun 30, 2025
@etiennesegonzac etiennesegonzac force-pushed the dev/sgz/rdar-153757448 branch from 0d25bf5 to 459d172 Compare June 30, 2025 11:56
@etiennesegonzac etiennesegonzac added the skip-ews Applied to prevent a change from being run on EWS label Jun 30, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 459d172)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
  🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 win
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
❌ 🛠 🧪 merge ⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
  🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@etiennesegonzac etiennesegonzac added the merge-queue Applied to send a pull request to merge-queue label Jun 30, 2025
@webkit-commit-queue
Copy link
Collaborator

No reviewer information in commit message, blocking PR #47298. Details: Build #23466

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Jun 30, 2025
@etiennesegonzac etiennesegonzac removed the merging-blocked Applied to prevent a change from being merged label Jun 30, 2025
@etiennesegonzac etiennesegonzac force-pushed the dev/sgz/rdar-153757448 branch from 459d172 to 28fa37b Compare June 30, 2025 12:02
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2025 •
edited
Loading

EWS run on current version of this PR (hash 28fa37b)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
  🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 win
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
  🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@etiennesegonzac etiennesegonzac added the merge-queue Applied to send a pull request to merge-queue label Jun 30, 2025
@etiennesegonzac
Take view stability into account when updating Overlay Regions
7ebf83c 
https://bugs.webkit.org/show_bug.cgi?id=295100
<rdar://153757448>

Reviewed by Simon Fraser.

Pass along a boolean `stable` flag to the `_updateOverlayRegionRects`
method.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(configureScrollViewWithOverlayRegionsIDs):
Use `_isInStableState` to get the scrollview stability.
(-[WKWebView _updateOverlayRegions:destroyedLayers:]):
Pass the boolean down.
(-[WKWebView _updateOverlayRegionsForCustomContentView]):
Always assume we're stable here.
* Source/WebKit/UIProcess/ios/WKBaseScrollView.h:
* Source/WebKit/UIProcess/ios/WKBaseScrollView.mm:
(-[WKBaseScrollView _updateOverlayRegionRects:whileStable:]):
(-[WKBaseScrollView _updateOverlayRegionRects:]): Deleted.
Update the stub.

Canonical link: https://commits.webkit.org/296792@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296792@main (7ebf83c): https://commits.webkit.org/296792@main

Reviewed commits have been landed. Closing PR #47298 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7ebf83c into WebKit:main Jun 30, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@mwyrzykowski mwyrzykowski Awaiting requested review from mwyrzykowski

Assignees

@etiennesegonzac etiennesegonzac

Labels
Scrolling Bugs related to main thread and off-main thread scrolling skip-ews Applied to prevent a change from being run on EWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etiennesegonzac @webkit-early-warning-system @webkit-commit-queue @smfr