Skip to content

Add a test for a release assert in CSSPrimitiveValue::create via ExtractorCustom::extractClip #47287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Add a test for a release assert in CSSPrimitiveValue::create via ExtractorCustom::extractClip #47287

merged 1 commit into from
Jun 30, 2025
+20 −0

Conversation

fred-wang
Copy link
Contributor

@fred-wang fred-wang commented Jun 27, 2025 •
edited by webkit-early-warning-system
Loading

7b40858

Add a test for a release assert in CSSPrimitiveValue::create via ExtractorCustom::extractClip
https://bugs.webkit.org/show_bug.cgi?id=293966

Reviewed by Ryosuke Niwa.

Fixed by https://commits.webkit.org/296743@main

* LayoutTests/fast/css/css-typed-om/css-builder-converter-clip-viewport-dimension-without-renderview-crash-expected.txt: Added.
* LayoutTests/fast/css/css-typed-om/css-builder-converter-clip-viewport-dimension-without-renderview-crash.html: Added.

Canonical link: https://commits.webkit.org/296822@main

5704181

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@fred-wang fred-wang self-assigned this Jun 27, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 27, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 5f7899c)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 win
❌ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
❌ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🛠 gtk
❌ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
❌ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ❌ 🛠 playstation
❌ 🛠 tv ❌ 🛠 mac-safer-cpp
❌ 🛠 tv-sim
❌ 🛠 watch
❌ 🛠 watch-sim

@fred-wang fred-wang added the CSS Cascading Style Sheets implementation label Jun 27, 2025
@fred-wang fred-wang requested review from weinig and anttijk and removed request for weinig June 27, 2025 09:31
@weinig
Copy link
Contributor

weinig commented Jun 27, 2025

I'd like to handle this differently and for all length cases. I have a PR up for this that I am completing here: #46977

@fred-wang
Copy link
Contributor Author

@weinig OK, sounds good to me.

@weinig
Copy link
Contributor

weinig commented Jun 27, 2025

Let's close this then.

@weinig weinig closed this Jun 27, 2025
@fred-wang
Copy link
Contributor Author

@weinig it seems you haven't added a test for bug 293966 though, so I'll reopen and land the test.

@fred-wang fred-wang reopened this Jun 30, 2025
@fred-wang fred-wang changed the title Ignore clip property when length conversion fails. Add a test for a release assert in CSSPrimitiveValue::create via ExtractorCustom::extractClip Jun 30, 2025
@fred-wang fred-wang force-pushed the eng/Release-assert-in-CSSPrimitiveValue-create-via-ExtractorCustom-extractClip branch from 5f7899c to 5704181 Compare June 30, 2025 06:56
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 30, 2025 •
edited
Loading

EWS run on current version of this PR (hash 5704181)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 30, 2025
@fred-wang fred-wang added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed merging-blocked Applied to prevent a change from being merged labels Jun 30, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Failed gtk-wk2 checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #47287 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jun 30, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #61880.

@fred-wang fred-wang added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jun 30, 2025
@fred-wang
Add a test for a release assert in CSSPrimitiveValue::create via Extr…
7b40858 
…actorCustom::extractClip

https://bugs.webkit.org/show_bug.cgi?id=293966

Reviewed by Ryosuke Niwa.

Fixed by https://commits.webkit.org/296743@main

* LayoutTests/fast/css/css-typed-om/css-builder-converter-clip-viewport-dimension-without-renderview-crash-expected.txt: Added.
* LayoutTests/fast/css/css-typed-om/css-builder-converter-clip-viewport-dimension-without-renderview-crash.html: Added.

Canonical link: https://commits.webkit.org/296822@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Release-assert-in-CSSPrimitiveValue-create-via-ExtractorCustom-extractClip branch from 5704181 to 7b40858 Compare June 30, 2025 20:12
@webkit-commit-queue
Copy link
Collaborator

Committed 296822@main (7b40858): https://commits.webkit.org/296822@main

Reviewed commits have been landed. Closing PR #47287 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7b40858 into WebKit:main Jun 30, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa approved these changes

@anttijk anttijk Awaiting requested review from anttijk

@weinig weinig Awaiting requested review from weinig

Assignees

@fred-wang fred-wang

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fred-wang @webkit-early-warning-system @weinig @webkit-ews-buildbot @webkit-commit-queue @rniwa