Skip to content

Change links from trac.webkit.org/browser/trunk to github.com/WebKit/WebKit/blob/main. #47263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Change links from trac.webkit.org/browser/trunk to github.com/WebKit/WebKit/blob/main. #47263

merged 1 commit into from
Jun 30, 2025
+17 −17

Conversation

bls1999
Copy link
Contributor

@bls1999 bls1999 commented Jun 26, 2025 •
edited by webkit-early-warning-system
Loading

2f67f45

Change links from trac.webkit.org/browser/trunk to github.com/WebKit/WebKit/blob/main.
https://bugs.webkit.org/show_bug.cgi?id=295064
rdar://154434652

Reviewed by Alexey Proskuryakov.

Some links to trac.webkit.org/browser/trunk/* still exist in the repo. This
makes tools like `webkit-patch rebaseline-server` generate a "View test" link
back to trac.webkit.org instead of GitHub.

So, this change replaces all instances of trac.webkit.org/browser/trunk with
github.com/WebKit/WebKit/blob/main.

* Tools/CISupport/build-webkit-org/public_html/TestFailures/scripts/ui.js:
    -> (ui.urlForTest): Change URL to https://github.com/WebKit/WebKit/blob/main/*.
* Tools/CISupport/ews-app/ews/views/statusbubble.py: Ditto.
* Tools/Scripts/webkitpy/common/config/urls.py: Ditto.
* Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Ditto.
* Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js:
    -> (getTracUrl): Rename to `getRepoUrl`.
* Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/main.js:
    -> (selectTest): Change invocation of `getTracUrl` to `getRepoUrl`.
    -> (updateState): Ditto.

Canonical link: https://commits.webkit.org/296815@main

1a0b5de

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🧪 services ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@bls1999 bls1999 self-assigned this Jun 26, 2025
@bls1999 bls1999 added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 26, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 6cca832)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🧪 services ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2 ⏳ 🛠 playstation
✅ 🛠 tv ⏳ 🛠 mac-safer-cpp
⏳ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2025 •
edited
Loading

EWS run on previous version of this PR (hash ca0c7da)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🧪 services ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2 ⏳ 🛠 playstation
✅ 🛠 tv ⏳ 🛠 mac-safer-cpp
⏳ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@bls1999 bls1999 changed the title Change links from trac.webkit.org/browser/trunk to github.com/webkit/webkit/blob/main. Change links from trac.webkit.org/browser/trunk to github.com/WebKit/WebKit/blob/main. Jun 26, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2025 •
edited
Loading

EWS run on current version of this PR (hash 1a0b5de)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🧪 services ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@bls1999 bls1999 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 30, 2025
@bls1999
Change links from trac.webkit.org/browser/trunk to github.com/WebKit/…
2f67f45 
…WebKit/blob/main.

https://bugs.webkit.org/show_bug.cgi?id=295064
rdar://154434652

Reviewed by Alexey Proskuryakov.

Some links to trac.webkit.org/browser/trunk/* still exist in the repo. This
makes tools like `webkit-patch rebaseline-server` generate a "View test" link
back to trac.webkit.org instead of GitHub.

So, this change replaces all instances of trac.webkit.org/browser/trunk with
github.com/WebKit/WebKit/blob/main.

* Tools/CISupport/build-webkit-org/public_html/TestFailures/scripts/ui.js:
    -> (ui.urlForTest): Change URL to https://github.com/WebKit/WebKit/blob/main/*.
* Tools/CISupport/ews-app/ews/views/statusbubble.py: Ditto.
* Tools/Scripts/webkitpy/common/config/urls.py: Ditto.
* Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Ditto.
* Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js:
    -> (getTracUrl): Rename to `getRepoUrl`.
* Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/main.js:
    -> (selectTest): Change invocation of `getTracUrl` to `getRepoUrl`.
    -> (updateState): Ditto.

Canonical link: https://commits.webkit.org/296815@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296815@main (2f67f45): https://commits.webkit.org/296815@main

Reviewed commits have been landed. Closing PR #47263 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2f67f45 into WebKit:main Jun 30, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aproskuryakov aproskuryakov aproskuryakov approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@gsnedders gsnedders Awaiting requested review from gsnedders gsnedders is a code owner

@aj062 aj062 Awaiting requested review from aj062 aj062 is a code owner

@ryanhaddad ryanhaddad Awaiting requested review from ryanhaddad ryanhaddad is a code owner

@briannafan briannafan Awaiting requested review from briannafan briannafan is a code owner

Assignees

@bls1999 bls1999

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bls1999 @webkit-early-warning-system @webkit-commit-queue @aproskuryakov