Skip to content

Stop using UncheckedKey containers in WebCore/editing #47249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

Stop using UncheckedKey containers in WebCore/editing #47249

merged 1 commit into from
Jun 26, 2025

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Jun 26, 2025 •
edited by webkit-early-warning-system
Loading

ddbec7b

Stop using UncheckedKey containers in WebCore/editing
https://bugs.webkit.org/show_bug.cgi?id=295041

Reviewed by Darin Adler.

Stop using UncheckedKey containers in WebCore/editing. This tested as
performance neutral on Speedometer.

* Source/WebCore/editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
* Source/WebCore/editing/EditCommand.h:
* Source/WebCore/editing/EditorCommand.cpp:
* Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::isElementExcludedByRule):
* Source/WebCore/editing/MarkupAccumulator.h:
* Source/WebCore/editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::replace):
* Source/WebCore/editing/TextManipulationController.h:
* Source/WebCore/editing/cocoa/AlternativeTextContextController.h:
* Source/WebCore/editing/cocoa/HTMLConverter.mm:
* Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::replaceRichContentWithAttachments):
(WebCore::createFragment):
(WebCore::sanitizeMarkupWithArchive):
* Source/WebCore/editing/markup.cpp:
(WebCore::replaceSubresourceURLs):
* Source/WebCore/editing/markup.h:

Canonical link: https://commits.webkit.org/296689@main

773f276

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez requested a review from rniwa as a code owner June 26, 2025 17:50
@cdumez cdumez self-assigned this Jun 26, 2025
@cdumez cdumez added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Jun 26, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2025 •
edited
Loading

EWS run on current version of this PR (hash 773f276)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2025
@cdumez
Stop using UncheckedKey containers in WebCore/editing
ddbec7b 
https://bugs.webkit.org/show_bug.cgi?id=295041

Reviewed by Darin Adler.

Stop using UncheckedKey containers in WebCore/editing. This tested as
performance neutral on Speedometer.

* Source/WebCore/editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
* Source/WebCore/editing/EditCommand.h:
* Source/WebCore/editing/EditorCommand.cpp:
* Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendNamespace):
(WebCore::isElementExcludedByRule):
* Source/WebCore/editing/MarkupAccumulator.h:
* Source/WebCore/editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::replace):
* Source/WebCore/editing/TextManipulationController.h:
* Source/WebCore/editing/cocoa/AlternativeTextContextController.h:
* Source/WebCore/editing/cocoa/HTMLConverter.mm:
* Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::replaceRichContentWithAttachments):
(WebCore::createFragment):
(WebCore::sanitizeMarkupWithArchive):
* Source/WebCore/editing/markup.cpp:
(WebCore::replaceSubresourceURLs):
* Source/WebCore/editing/markup.h:

Canonical link: https://commits.webkit.org/296689@main
@webkit-commit-queue webkit-commit-queue force-pushed the 295041_editing_checked_maps branch from 773f276 to ddbec7b Compare June 26, 2025 22:48
@webkit-commit-queue
Copy link
Collaborator

Committed 296689@main (ddbec7b): https://commits.webkit.org/296689@main

Reviewed commits have been landed. Closing PR #47249 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ddbec7b into WebKit:main Jun 26, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@cdumez cdumez

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler