Skip to content

Unreviewed, reverting 296663@main (21fdaf35464f) #47239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

Unreviewed, reverting 296663@main (21fdaf35464f) #47239

merged 1 commit into from
Jun 26, 2025

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Jun 26, 2025 •
edited by webkit-early-warning-system
Loading

e3f69f9

Unreviewed, reverting 296663@main (21fdaf35464f)
https://bugs.webkit.org/show_bug.cgi?id=295030
rdar://154396798

Re-land 296657@main with member function guard removed

Reverted change:

    Unreviewed, reverting 296657@main.
    https://bugs.webkit.org/show_bug.cgi?id=295028
    296663@main (21fdaf35464f)

Canonical link: https://commits.webkit.org/296670@main

bb34fcc

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ❌ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski requested a review from cdumez as a code owner June 26, 2025 15:05
@mwyrzykowski mwyrzykowski self-assigned this Jun 26, 2025
@mwyrzykowski mwyrzykowski added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 26, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2025 •
edited
Loading

EWS run on current version of this PR (hash bb34fcc)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ❌ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 26, 2025
mwyrzykowski
mwyrzykowski commented Jun 26, 2025
View reviewed changes
Source/WebKit/UIProcess/WebProcessPool.h
@@ -640,6 +640,7 @@ class WebProcessPool final
#if PLATFORM(IOS_FAMILY)
void didRefreshDisplay();
#endif
void suppressEDR(bool);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may want to have this behind PLATFORM(COCOA) but not strictly needed

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 26, 2025
@mwyrzykowski mwyrzykowski added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jun 26, 2025
@mwyrzykowski
Unreviewed, reverting 296663@main (21fdaf3)
e3f69f9 
https://bugs.webkit.org/show_bug.cgi?id=295030
rdar://154396798

Re-land 296657@main with member function guard removed

Reverted change:

    Unreviewed, reverting 296657@main.
    https://bugs.webkit.org/show_bug.cgi?id=295028
    296663@main (21fdaf3)

Canonical link: https://commits.webkit.org/296670@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Re-land-296657-main-with-member-function-guard-removed branch from bb34fcc to e3f69f9 Compare June 26, 2025 17:52
@webkit-commit-queue
Copy link
Collaborator

Committed 296670@main (e3f69f9): https://commits.webkit.org/296670@main

Reviewed commits have been landed. Closing PR #47239 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e3f69f9 into WebKit:main Jun 26, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@mwyrzykowski mwyrzykowski

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mwyrzykowski @webkit-early-warning-system @webkit-commit-queue @webkit-ews-buildbot