Skip to content

Improve StyleRareInheritedData bit-packing #47222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

Improve StyleRareInheritedData bit-packing #47222

merged 1 commit into from
Jun 26, 2025
+3 −4

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Jun 26, 2025 •
edited by webkit-early-warning-system
Loading

758f0dd

Improve StyleRareInheritedData bit-packing
https://bugs.webkit.org/show_bug.cgi?id=295016
rdar://154362213

Reviewed by Aditya Keerthi.

Fill a 1-bit spot that's revealed by dump-class-layout

* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:

Canonical link: https://commits.webkit.org/296654@main

caf4193

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
✅ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m self-assigned this Jun 26, 2025
@nt1m nt1m added the CSS Cascading Style Sheets implementation label Jun 26, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2025 •
edited
Loading

EWS run on current version of this PR (hash caf4193)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
✅ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested review from darinadler, smfr, heycam and anttijk and removed request for darinadler June 26, 2025 05:54
@nt1m nt1m mentioned this pull request Jun 26, 2025
Merged
@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2025
@nt1m
Improve StyleRareInheritedData bit-packing
758f0dd 
https://bugs.webkit.org/show_bug.cgi?id=295016
rdar://154362213

Reviewed by Aditya Keerthi.

Fill a 1-bit spot that's revealed by dump-class-layout

* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:

Canonical link: https://commits.webkit.org/296654@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Improve-StyleRareInheritedData-bit-packing branch from caf4193 to 758f0dd Compare June 26, 2025 06:23
@webkit-commit-queue
Copy link
Collaborator

Committed 296654@main (758f0dd): https://commits.webkit.org/296654@main

Reviewed commits have been landed. Closing PR #47222 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 758f0dd into WebKit:main Jun 26, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxlcoder pxlcoder pxlcoder approved these changes

@smfr smfr Awaiting requested review from smfr

@heycam heycam Awaiting requested review from heycam

@anttijk anttijk Awaiting requested review from anttijk

@darinadler darinadler Awaiting requested review from darinadler

Assignees

@nt1m nt1m

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nt1m @webkit-early-warning-system @webkit-commit-queue @pxlcoder