Skip to content

Import the latest cookie prefixes and cookie-store special names WPTs #47219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Import the latest cookie prefixes and cookie-store special names WPTs #47219

wants to merge 1 commit into from

Conversation

yoavweiss
Copy link
Contributor

@yoavweiss yoavweiss commented Jun 26, 2025 •
edited by webkit-early-warning-system
Loading

1a992d9

Import the latest cookie prefixes and cookie-store special names WPTs
https://bugs.webkit.org/show_bug.cgi?id=295007

Reviewed by NOBODY (OOPS!).

This imports the latest WPTs for both the cookieStore API and cookies prefixes.
Upstream commit: web-platform-tests/wpt@55d329c

* LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_special_names.https.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_special_names.https.any.js:
(string_appeared_here.forEach.prefix.promise_test.async testCase):
(promise_test.async testCase):
* LayoutTests/imported/w3c/web-platform-tests/cookies/prefix/__HostHttp.https.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/cookies/prefix/__HostHttp.https.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/cookies/prefix/__Http.https.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/cookies/prefix/__Http.https.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/cookies/prefix/w3c-import.log:

1a992d9

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@yoavweiss yoavweiss self-assigned this Jun 26, 2025
@yoavweiss yoavweiss added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 26, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2025 •
edited
Loading

EWS run on previous version of this PR (hash c81f0cf)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ⏳ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@yoavweiss yoavweiss requested review from cdumez and annevk June 26, 2025 03:00
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 26, 2025
@yoavweiss
Import the latest cookie prefixes and cookie-store special names WPTs
1a992d9 
https://bugs.webkit.org/show_bug.cgi?id=295007

Reviewed by NOBODY (OOPS!).

This imports the latest WPTs for both the cookieStore API and cookies prefixes.
Upstream commit: web-platform-tests/wpt@55d329c

* LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_special_names.https.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_special_names.https.any.js:
(string_appeared_here.forEach.prefix.promise_test.async testCase):
(promise_test.async testCase):
* LayoutTests/imported/w3c/web-platform-tests/cookies/prefix/__HostHttp.https.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/cookies/prefix/__HostHttp.https.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/cookies/prefix/__Http.https.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/cookies/prefix/__Http.https.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/cookies/prefix/w3c-import.log:
@yoavweiss yoavweiss removed the merging-blocked Applied to prevent a change from being merged label Jun 26, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 26, 2025 •
edited
Loading

EWS run on current version of this PR (hash 1a992d9)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 26, 2025
annevk
annevk reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems okay, modulo EWS failures, but maybe we can rename the tests away from .tentative upstream first? I'll land the specification change today or tomorrow.

@yoavweiss
Copy link
Contributor Author

modulo EWS failures

Failures seem related to the fact that the fail output prints a random value. I'll change that as well upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@cdumez cdumez Awaiting requested review from cdumez

Assignees

@yoavweiss yoavweiss

Labels
merging-blocked Applied to prevent a change from being merged New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoavweiss @webkit-early-warning-system @annevk @webkit-ews-buildbot