Skip to content

Show the commit identifier in scheduled build requests #47207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Show the commit identifier in scheduled build requests #47207

merged 1 commit into from
Jun 27, 2025

Conversation

martadarbinyan
Copy link
Contributor

@martadarbinyan martadarbinyan commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

5b25964

Show the commit identifier in scheduled build requests
rdar://137161182
https://bugs.webkit.org/show_bug.cgi?id=294993

Reviewed by Aakash Jain.

Add the commit identifier in scheduled build requests within Webkit EWS. It will help to find the commit number for debugging and cleaning up the broken build requests in backlog.

* Tools/CISupport/ews-build/steps.py:
(Trigger.propertiesToPassToTriggers):

Canonical link: https://commits.webkit.org/296740@main

74df247

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🧪 services ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@martadarbinyan martadarbinyan self-assigned this Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 74df247)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🧪 services ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

aj062
aj062 approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be nice if you can also test it on uat/dev instance.

@martadarbinyan martadarbinyan added the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2025
@martadarbinyan
Show the commit identifier in scheduled build requests
5b25964 
rdar://137161182
https://bugs.webkit.org/show_bug.cgi?id=294993

Reviewed by Aakash Jain.

Add the commit identifier in scheduled build requests within Webkit EWS. It will help to find the commit number for debugging and cleaning up the broken build requests in backlog.

* Tools/CISupport/ews-build/steps.py:
(Trigger.propertiesToPassToTriggers):

Canonical link: https://commits.webkit.org/296740@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296740@main (5b25964): https://commits.webkit.org/296740@main

Reviewed commits have been landed. Closing PR #47207 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5b25964 into WebKit:main Jun 27, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj062 aj062 aj062 approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@ryanhaddad ryanhaddad Awaiting requested review from ryanhaddad ryanhaddad is a code owner

@briannafan briannafan Awaiting requested review from briannafan briannafan is a code owner

Assignees

@martadarbinyan martadarbinyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martadarbinyan @webkit-early-warning-system @webkit-commit-queue @aj062