-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[SaferCPP] Improve smart pointer adoption in the UIProcess C API, part 3/3 #47206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SaferCPP] Improve smart pointer adoption in the UIProcess C API, part 3/3 #47206
Conversation
EWS run on previous version of this PR (hash f6d1647) |
Safer C++ Build #41597 (f6d1647)❌ Found 2 failing files with 6 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
f6d1647
to
964417a
Compare
EWS run on previous version of this PR (hash 964417a) |
964417a
to
b51b5c6
Compare
EWS run on current version of this PR (hash b51b5c6) |
…t 3/3 https://bugs.webkit.org/show_bug.cgi?id=294994 rdar://154329301 Reviewed by Chris Dumez. Finish the last two files with failing smart pointer warnings in the UIProcess C API: - Source/WebKit/UIProcess/API/C/WKContext.cpp - Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp * Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: * Source/WebKit/UIProcess/API/C/WKContext.cpp: (WKContextSetClient): (WKContextSetInjectedBundleClient): (WKContextSetDownloadClient): (WKContextPostMessageToInjectedBundle): (WKContextAddVisitedLink): (WKContextSetAlwaysUsesComplexTextCodePath): (WKContextSetDisableFontSubpixelAntialiasingForTesting): (WKContextRegisterURLSchemeAsEmptyDocument): (WKContextRegisterURLSchemeAsSecure): (WKContextRegisterURLSchemeAsBypassingContentSecurityPolicy): (WKContextRegisterURLSchemeAsCachePartitioned): (WKContextRegisterURLSchemeAsCanDisplayOnlyIfCanRequest): (WKContextSetDomainRelaxationForbiddenForURLScheme): (WKContextGetGeolocationManager): (WKContextGetNotificationManager): (WKContextStartMemorySampler): (WKContextStopMemorySampler): (WKContextDisableProcessTermination): (WKContextEnableProcessTermination): (WKContextSetHTTPPipeliningEnabled): (WKContextWarmInitialProcess): (WKContextSetJavaScriptConfigurationFileEnabled): (WKContextGarbageCollectJavaScriptObjects): (WKContextSetJavaScriptGarbageCollectorTimerEnabled): (WKContextSetMemoryCacheDisabled): (WKContextSetFontAllowList): (WKContextTerminateServiceWorkers): (WKContextClearCurrentModifierStateForTesting): (WKContextSetLocalhostAliases): (WKContextSetResourceMonitorURLsForTesting): * Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreTerminateNetworkProcess): (WKWebsiteDataStoreGetNetworkProcessIdentifier): (WKWebsiteDataStoreRemoveITPDataForDomain): (WKWebsiteDataStoreDoesStatisticsDomainIDExistInDatabase): (WKWebsiteDataStoreSetServiceWorkerFetchTimeoutForTesting): (WKWebsiteDataStoreResetServiceWorkerFetchTimeoutForTesting): (WKWebsiteDataStoreSetResourceLoadStatisticsEnabled): (WKWebsiteDataStoreIsStatisticsEphemeral): (WKWebsiteDataStoreGetResourceLoadStatisticsEnabled): (WKWebsiteDataStoreSetResourceLoadStatisticsDebugMode): (WKWebsiteDataStoreSyncLocalStorage): (WKWebsiteDataStoreGetHTTPCookieStore): (WKWebsiteDataStoreSetResourceLoadStatisticsDebugModeWithCompletionHandler): (WKWebsiteDataStoreSetResourceLoadStatisticsPrevalentResourceForDebugMode): (WKWebsiteDataStoreSetStatisticsLastSeen): (WKWebsiteDataStoreSetStatisticsMergeStatistic): (WKWebsiteDataStoreSetStatisticsExpiredStatistic): (WKWebsiteDataStoreSetStatisticsPrevalentResource): (WKWebsiteDataStoreSetStatisticsVeryPrevalentResource): (WKWebsiteDataStoreDumpResourceLoadStatistics): (WKWebsiteDataStoreIsStatisticsPrevalentResource): (WKWebsiteDataStoreIsStatisticsVeryPrevalentResource): (WKWebsiteDataStoreIsStatisticsRegisteredAsSubresourceUnder): (WKWebsiteDataStoreIsStatisticsRegisteredAsSubFrameUnder): (WKWebsiteDataStoreIsStatisticsRegisteredAsRedirectingTo): (WKWebsiteDataStoreSetStatisticsHasHadUserInteraction): (WKWebsiteDataStoreIsStatisticsHasHadUserInteraction): (WKWebsiteDataStoreIsStatisticsOnlyInDatabaseOnce): (WKWebsiteDataStoreSetStatisticsGrandfathered): (WKWebsiteDataStoreIsStatisticsGrandfathered): (WKWebsiteDataStoreSetStatisticsSubframeUnderTopFrameOrigin): (WKWebsiteDataStoreSetStatisticsSubresourceUnderTopFrameOrigin): (WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectTo): (WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectFrom): (WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectTo): (WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectFrom): (WKWebsiteDataStoreSetStatisticsCrossSiteLoadWithLinkDecoration): (WKWebsiteDataStoreSetStatisticsTimeToLiveUserInteraction): (WKWebsiteDataStoreStatisticsProcessStatisticsAndDataRecords): (WKWebsiteDataStoreStatisticsUpdateCookieBlocking): (WKWebsiteDataStoreSetResourceLoadStatisticsTimeAdvanceForTesting): (WKWebsiteDataStoreSetStatisticsIsRunningTest): (WKWebsiteDataStoreSetStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval): (WKWebsiteDataStoreSetStatisticsMinimumTimeBetweenDataRecordsRemoval): (WKWebsiteDataStoreSetStatisticsGrandfatheringTime): (WKWebsiteDataStoreSetStatisticsMaxStatisticsEntries): (WKWebsiteDataStoreSetStatisticsPruneEntriesDownTo): (WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStore): (WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStoreModifiedSinceHours): (WKWebsiteDataStoreStatisticsClearThroughWebsiteDataRemoval): (WKWebsiteDataStoreStatisticsDeleteCookiesForTesting): (WKWebsiteDataStoreStatisticsHasLocalStorage): (WKWebsiteDataStoreSetStatisticsCacheMaxAgeCap): (WKWebsiteDataStoreStatisticsHasIsolatedSession): (WKWebsiteDataStoreSetResourceLoadStatisticsShouldDowngradeReferrerForTesting): (WKWebsiteDataStoreSetResourceLoadStatisticsShouldBlockThirdPartyCookiesForTesting): (WKWebsiteDataStoreSetResourceLoadStatisticsFirstPartyWebsiteDataRemovalModeForTesting): (WKWebsiteDataStoreSetResourceLoadStatisticsToSameSiteStrictCookiesForTesting): (WKWebsiteDataStoreSetResourceLoadStatisticsFirstPartyHostCNAMEDomainForTesting): (WKWebsiteDataStoreSetResourceLoadStatisticsThirdPartyCNAMEDomainForTesting): (WKWebsiteDataStoreRemoveAllFetchCaches): (WKWebsiteDataStoreRemoveNetworkCache): (WKWebsiteDataStoreRemoveMemoryCaches): (WKWebsiteDataStoreRemoveFetchCacheForOrigin): (WKWebsiteDataStoreRemoveAllIndexedDatabases): (WKWebsiteDataStoreRemoveLocalStorage): (WKWebsiteDataStoreRemoveAllServiceWorkerRegistrations): (WKWebsiteDataStoreGetFetchCacheOrigins): (WKWebsiteDataStoreGetFetchCacheSizeForOrigin): (WKWebsiteDataStoreClearAllDeviceOrientationPermissions): (WKWebsiteDataStoreClearPrivateClickMeasurementsThroughWebsiteDataRemoval): (WKWebsiteDataStoreSetCacheModelSynchronouslyForTesting): (WKWebsiteDataStoreResetQuota): (WKWebsiteDataStoreResetStoragePersistedState): (WKWebsiteDataStoreClearStorage): (WKWebsiteDataStoreSetOriginQuotaRatioEnabled): (WKWebsiteDataStoreUpdateBundleIdentifierInNetworkProcess): (WKWebsiteDataStoreClearBundleIdentifierInNetworkProcess): (WKWebsiteDataStoreGetAllStorageAccessEntries): (WKWebsiteDataStoreResetResourceMonitorThrottler): Canonical link: https://commits.webkit.org/296672@main
b51b5c6
to
6331db8
Compare
Committed 296672@main (6331db8): https://commits.webkit.org/296672@main Reviewed commits have been landed. Closing PR #47206 and removing active labels. |
6331db8
b51b5c6