Skip to content

ssue caused by vertical-align on root node with rem/rex type #47203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

ssue caused by vertical-align on root node with rem/rex type #47203

merged 1 commit into from
Jun 26, 2025

Conversation

anil-hebbar
Copy link
Contributor

@anil-hebbar anil-hebbar commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

6165a03

ssue caused by vertical-align on root node with rem/rex type
https://bugs.webkit.org/show_bug.cgi?id=294451
rdar://151618114

Reviewed by Sam Weinig.

Issue caused by vertical-align on root node with rem/rex type
https://bugs.webkit.org/show_bug.cgi?id=294451
rdar://151618114

Reviewed by Sam Weinig.

The issue is when doing vertical-align of type rem or rex, it is assumed that there
is a valid root style. This is not so in case of root node and this was causing
issues (root style is NULL ofr root element).
The fix was built over the following PR: #46917
The usage of new BuilderConverter::convertLength as opposed to builderState.cssToLengthConversionData in function BuilderCustom::applyValueVerticalAlign fixed the issue combined with the earlier
changes fixed the issue

Canonical link: https://commits.webkit.org/296678@main

b7c36e8

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@anil-hebbar anil-hebbar self-assigned this Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash b7c36e8)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@anil-hebbar anil-hebbar added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 25, 2025
@anil-hebbar anil-hebbar requested review from aproskuryakov, anttijk, weinig, rniwa and nt1m and removed request for aproskuryakov and anttijk June 25, 2025 20:16
@weinig
Copy link
Contributor

weinig commented Jun 26, 2025

Looks like maybe your commit message got malformed? I see some duplicated lines.

@anil-hebbar anil-hebbar changed the title ssue caused by vertical-align on root node with rem/rex type Issue caused by vertical-align on root node with rem/rex type Jun 26, 2025
@weinig weinig added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 26, 2025
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jun 26, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #61495.

@anil-hebbar @weinig
ssue caused by vertical-align on root node with rem/rex type
6165a03 
https://bugs.webkit.org/show_bug.cgi?id=294451
rdar://151618114

Reviewed by Sam Weinig.

Issue caused by vertical-align on root node with rem/rex type
https://bugs.webkit.org/show_bug.cgi?id=294451
rdar://151618114

Reviewed by Sam Weinig.

The issue is when doing vertical-align of type rem or rex, it is assumed that there
is a valid root style. This is not so in case of root node and this was causing
issues (root style is NULL ofr root element).
The fix was built over the following PR: WebKit#46917.
The usage of new BuilderConverter::convertLength as opposed to builderState.cssToLengthConversionData in function BuilderCustom::applyValueVerticalAlign fixed the issue combined with the earlier
changes fixed the issue

Canonical link: https://commits.webkit.org/296678@main
@webkit-commit-queue webkit-commit-queue changed the title Issue caused by vertical-align on root node with rem/rex type ssue caused by vertical-align on root node with rem/rex type Jun 26, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the ahebbar-ver-rem/PR-151618114_1 branch from b7c36e8 to 6165a03 Compare June 26, 2025 20:12
@webkit-commit-queue
Copy link
Collaborator

Committed 296678@main (6165a03): https://commits.webkit.org/296678@main

Reviewed commits have been landed. Closing PR #47203 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6165a03 into WebKit:main Jun 26, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weinig weinig weinig approved these changes

@aproskuryakov aproskuryakov Awaiting requested review from aproskuryakov

@rniwa rniwa Awaiting requested review from rniwa

@nt1m nt1m Awaiting requested review from nt1m

@alanbaradlay alanbaradlay Awaiting requested review from alanbaradlay

@anttijk anttijk Awaiting requested review from anttijk

Assignees

@anil-hebbar anil-hebbar

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anil-hebbar @webkit-early-warning-system @weinig @webkit-ews-buildbot @webkit-commit-queue