Skip to content

[iOS] TestWebKitAPI.EditorStateTests.SelectedTextRange_CaretSelectionWithZoom is a flaky failure #47202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

[iOS] TestWebKitAPI.EditorStateTests.SelectedTextRange_CaretSelectionWithZoom is a flaky failure #47202

merged 1 commit into from
Jun 26, 2025

Conversation

pxlcoder
Copy link
Member

@pxlcoder pxlcoder commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

f0ec0e0

[iOS] TestWebKitAPI.EditorStateTests.SelectedTextRange_CaretSelectionWithZoom is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=294922
rdar://154216068

Reviewed by Abrar Rahman Protyasha.

Wait for a visible content rect update before setting the zoom scale, so that
it does get overridden on next layer tree commit.

Additionally, treat the zoom scale change as a user triggered zoom by swizzling
the state on the gesture recognizer. Without this, the zoom scale may get when
the viewport configuration changes.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
(TestWebKitAPI::TEST(EditorStateTests, SelectedTextRange_CaretSelectionWithZoom)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::UNIFIED_PDF_TEST):

Adopt the new helper in another test.

* Tools/TestWebKitAPI/cocoa/TestWKWebView.h:
* Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView setZoomScaleSimulatingUserTriggeredZoom:]):

Canonical link: https://commits.webkit.org/296645@main

4cc3509

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pxlcoder pxlcoder self-assigned this Jun 25, 2025
@pxlcoder pxlcoder added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 4cc3509)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pxlcoder pxlcoder added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2025
@pxlcoder
[iOS] TestWebKitAPI.EditorStateTests.SelectedTextRange_CaretSelection…
f0ec0e0 
…WithZoom is a flaky failure

https://bugs.webkit.org/show_bug.cgi?id=294922
rdar://154216068

Reviewed by Abrar Rahman Protyasha.

Wait for a visible content rect update before setting the zoom scale, so that
it does get overridden on next layer tree commit.

Additionally, treat the zoom scale change as a user triggered zoom by swizzling
the state on the gesture recognizer. Without this, the zoom scale may get when
the viewport configuration changes.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
(TestWebKitAPI::TEST(EditorStateTests, SelectedTextRange_CaretSelectionWithZoom)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::UNIFIED_PDF_TEST):

Adopt the new helper in another test.

* Tools/TestWebKitAPI/cocoa/TestWKWebView.h:
* Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView setZoomScaleSimulatingUserTriggeredZoom:]):

Canonical link: https://commits.webkit.org/296645@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296645@main (f0ec0e0): https://commits.webkit.org/296645@main

Reviewed commits have been landed. Closing PR #47202 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f0ec0e0 into WebKit:main Jun 26, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprotyas aprotyas aprotyas approved these changes

@hortont424 hortont424 Awaiting requested review from hortont424

@whsieh whsieh Awaiting requested review from whsieh

@rr-codes rr-codes Awaiting requested review from rr-codes

@megangardner megangardner Awaiting requested review from megangardner

@jesxilin jesxilin Awaiting requested review from jesxilin

@lilyspiniolas lilyspiniolas Awaiting requested review from lilyspiniolas

Assignees

@pxlcoder pxlcoder

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pxlcoder @webkit-early-warning-system @webkit-commit-queue @aprotyas