Skip to content

[webkitapipy] Non-normalized paths treated as separate inputs #47197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

[webkitapipy] Non-normalized paths treated as separate inputs #47197

merged 1 commit into from
Jun 25, 2025
+18 −2

Conversation

emw-apple
Copy link
Contributor

@emw-apple emw-apple commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

73c3b7b

[webkitapipy] Non-normalized paths treated as separate inputs
rdar://154311830
https://bugs.webkit.org/show_bug.cgi?id=294986

Reviewed by Brianna Fan.

Use Path.resolve() instead of Path.absolute(). It ought to be safe from
causing incremental build breakage because these paths aren't emitted
back to Xcode, they are only used for internal bookkeeping.

* Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb.py:
(SDKDB._cache_hit_preparing_to_insert):
* Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb_unittest.py:

Canonical link: https://commits.webkit.org/296638@main

3617ef0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe
✅ 🧪 webkitpy   🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@emw-apple emw-apple self-assigned this Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 097115a)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
✅ 🧪 webkitpy ⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ⏳ 🛠 wpe-cairo
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2 ⏳ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress ⏳ 🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2 ⏳ 🛠 playstation
✅ 🛠 tv ⏳ 🛠 mac-safer-cpp
⏳ 🛠 tv-sim
⏳ 🛠 watch
✅ 🛠 watch-sim

@emw-apple emw-apple force-pushed the eng/webkitapipy-Non-normalized-paths-treated-as-separate-inputs branch from 097115a to edb703e Compare June 25, 2025 18:20
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on previous version of this PR (hash edb703e)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ⏳ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
  🛠 🧪 merge ✅ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@aproskuryakov
Copy link
Contributor

It ought to be safe from
causing incremental build breakage because these paths aren't emitted
back to Xcode, they are only used for internal bookkeeping.

Is there a reason to expect that it will stay this way? Even a comment could help avoid future mistakes sometimes.

@emw-apple emw-apple added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Jun 25, 2025
@emw-apple emw-apple force-pushed the eng/webkitapipy-Non-normalized-paths-treated-as-separate-inputs branch from edb703e to 3617ef0 Compare June 25, 2025 22:37
@emw-apple emw-apple added the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 3617ef0)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 api-wpe
✅ 🧪 webkitpy   🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@emw-apple
Copy link
Contributor Author

It ought to be safe from
causing incremental build breakage because these paths aren't emitted
back to Xcode, they are only used for internal bookkeeping.

Is there a reason to expect that it will stay this way?

Separation of concerns ought to help—the depfile given to Xcode is produced as a side effect of processing input paths in program.main(). So tracking input dependencies is handled before any path is stored in the sdkdb instance.

Even a comment could help avoid future mistakes sometimes.

Added a comment explaining the situation, thanks!

@emw-apple
[webkitapipy] Non-normalized paths treated as separate inputs
73c3b7b 
rdar://154311830
https://bugs.webkit.org/show_bug.cgi?id=294986

Reviewed by Brianna Fan.

Use Path.resolve() instead of Path.absolute(). It ought to be safe from
causing incremental build breakage because these paths aren't emitted
back to Xcode, they are only used for internal bookkeeping.

* Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb.py:
(SDKDB._cache_hit_preparing_to_insert):
* Tools/Scripts/libraries/webkitapipy/webkitapipy/sdkdb_unittest.py:

Canonical link: https://commits.webkit.org/296638@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/webkitapipy-Non-normalized-paths-treated-as-separate-inputs branch from 3617ef0 to 73c3b7b Compare June 25, 2025 23:08
@webkit-commit-queue
Copy link
Collaborator

Committed 296638@main (73c3b7b): https://commits.webkit.org/296638@main

Reviewed commits have been landed. Closing PR #47197 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 73c3b7b into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briannafan briannafan briannafan approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@gsnedders gsnedders Awaiting requested review from gsnedders gsnedders is a code owner

Assignees

@emw-apple emw-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emw-apple @webkit-early-warning-system @aproskuryakov @webkit-commit-queue @briannafan