Skip to content

[Swift in WebKit] Adopt Swift 6 across all of WebKit #47191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

[Swift in WebKit] Adopt Swift 6 across all of WebKit #47191

merged 1 commit into from
Jun 25, 2025

Conversation

rr-codes
Copy link
Contributor

@rr-codes rr-codes commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

13d0847

[Swift in WebKit] Adopt Swift 6 across all of WebKit
https://bugs.webkit.org/show_bug.cgi?id=294981
rdar://154307184

Reviewed by Elliott Williams.

Now that all WebKit code is Swift 6 compliant, adopt Swift 6 everywhere.

* Source/WebCore/PAL/Configurations/PAL.xcconfig:
* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/Configurations/WebKitSwift.xcconfig:
* Tools/MiniBrowser/Configurations/Base.xcconfig:
* Tools/SwiftBrowser/Configurations/Base.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestWebKitAPIBundle.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:

Canonical link: https://commits.webkit.org/296631@main

9be8571

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@rr-codes rr-codes requested a review from emw-apple as a code owner June 25, 2025 17:20
@rr-codes rr-codes self-assigned this Jun 25, 2025
@rr-codes rr-codes added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 7f35504)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 win
✅ 🧪 bindings ⏳ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac ⏳ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ⏳ 🛠 wpe-cairo
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios   🧪 mac-wk2 ⏳ 🛠 gtk
⏳ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 vision-sim   🧪 mac-wk2-stress ⏳ 🧪 api-gtk
⏳ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2 ⏳ 🛠 playstation
⏳ 🛠 tv   🛠 mac-safer-cpp ⏳ 🛠 jsc-armv7
⏳ 🛠 tv-sim ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch
⏳ 🛠 watch-sim

@rr-codes rr-codes force-pushed the eng/Swift-in-WebKit-Adopt-Swift-6-across-all-of-WebKit branch from 7f35504 to 9be8571 Compare June 25, 2025 17:23
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 9be8571)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@rr-codes rr-codes added the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
@rr-codes
[Swift in WebKit] Adopt Swift 6 across all of WebKit
13d0847 
https://bugs.webkit.org/show_bug.cgi?id=294981
rdar://154307184

Reviewed by Elliott Williams.

Now that all WebKit code is Swift 6 compliant, adopt Swift 6 everywhere.

* Source/WebCore/PAL/Configurations/PAL.xcconfig:
* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/Configurations/WebKitSwift.xcconfig:
* Tools/MiniBrowser/Configurations/Base.xcconfig:
* Tools/SwiftBrowser/Configurations/Base.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestWebKitAPIBundle.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:

Canonical link: https://commits.webkit.org/296631@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Swift-in-WebKit-Adopt-Swift-6-across-all-of-WebKit branch from 9be8571 to 13d0847 Compare June 25, 2025 20:22
@webkit-commit-queue
Copy link
Collaborator

Committed 296631@main (13d0847): https://commits.webkit.org/296631@main

Reviewed commits have been landed. Closing PR #47191 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 13d0847 into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emw-apple emw-apple emw-apple approved these changes

Assignees

@rr-codes rr-codes

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rr-codes @webkit-early-warning-system @webkit-commit-queue @emw-apple