Skip to content

REGRESSION (macOS Tahoe): 13x CSSViewportUnits API tests are constant failures #47190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

whsieh
Copy link
Member

@whsieh whsieh commented Jun 25, 2025

c4a44e4

REGRESSION (macOS Tahoe): 13x CSSViewportUnits API tests are constant failures
https://bugs.webkit.org/show_bug.cgi?id=294980
rdar://154219736

Reviewed by Simon Fraser.

After rdar://146130865, the width of the system legacy scrollbar on macOS has changed from 15 to 14
(i.e., the width exposed through `-[NSScrollerImp trackBoxWidth]` for a scrollbar with control size
`NSControlSizeRegular`). These API tests currently rely on a hard-coded size of 15, so they began
failing with small deltas.

To fix this, instead of hard-coding a new width here, we adjust the tests to directly ask the system
for the width via `-[NSScrollerImp trackBoxWidth]`.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:
(scrollbarSize):
(TEST(CSSViewportUnits, AllSame)):
(TEST(CSSViewportUnits, MinimumViewportInset)):
(TEST(CSSViewportUnits, MaximumViewportInset)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithZoom)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithZoom)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithWritingMode)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithWritingMode)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithFrame)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithFrame)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithBounds)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithBounds)):
(TEST(CSSViewportUnits, TopContentInset)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithTopContentInset)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithTopContentInset)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithContentInset)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithContentInset)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithSafeAreaInsets)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithSafeAreaInsets)):
(TEST(CSSViewportUnits, UnobscuredSizeOverridesIgnoreMinimumViewportInset)):
(TEST(CSSViewportUnits, UnobscuredSizeOverridesIgnoreMaximumViewportInset)):
(TEST(CSSViewportUnits, EmptyUnobscuredSizeOverrides)):
(TEST(CSSViewportUnits, SameUnobscuredSizeOverrides)):
(TEST(CSSViewportUnits, DifferentUnobscuredSizeOverrides)):
(TEST(CSSViewportUnits, SVGDocument)):

Canonical link: https://commits.webkit.org/296628@main

f1b823b

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@whsieh whsieh self-assigned this Jun 25, 2025
@whsieh whsieh added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 25, 2025
@whsieh whsieh added the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
@whsieh
Copy link
Member Author

whsieh commented Jun 25, 2025

Thanks for the review!

… failures

https://bugs.webkit.org/show_bug.cgi?id=294980
rdar://154219736

Reviewed by Simon Fraser.

After rdar://146130865, the width of the system legacy scrollbar on macOS has changed from 15 to 14
(i.e., the width exposed through `-[NSScrollerImp trackBoxWidth]` for a scrollbar with control size
`NSControlSizeRegular`). These API tests currently rely on a hard-coded size of 15, so they began
failing with small deltas.

To fix this, instead of hard-coding a new width here, we adjust the tests to directly ask the system
for the width via `-[NSScrollerImp trackBoxWidth]`.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:
(scrollbarSize):
(TEST(CSSViewportUnits, AllSame)):
(TEST(CSSViewportUnits, MinimumViewportInset)):
(TEST(CSSViewportUnits, MaximumViewportInset)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithZoom)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithZoom)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithWritingMode)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithWritingMode)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithFrame)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithFrame)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithBounds)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithBounds)):
(TEST(CSSViewportUnits, TopContentInset)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithTopContentInset)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithTopContentInset)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithContentInset)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithContentInset)):
(TEST(CSSViewportUnits, MinimumViewportInsetWithSafeAreaInsets)):
(TEST(CSSViewportUnits, MaximumViewportInsetWithSafeAreaInsets)):
(TEST(CSSViewportUnits, UnobscuredSizeOverridesIgnoreMinimumViewportInset)):
(TEST(CSSViewportUnits, UnobscuredSizeOverridesIgnoreMaximumViewportInset)):
(TEST(CSSViewportUnits, EmptyUnobscuredSizeOverrides)):
(TEST(CSSViewportUnits, SameUnobscuredSizeOverrides)):
(TEST(CSSViewportUnits, DifferentUnobscuredSizeOverrides)):
(TEST(CSSViewportUnits, SVGDocument)):

Canonical link: https://commits.webkit.org/296628@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296628@main (c4a44e4): https://commits.webkit.org/296628@main

Reviewed commits have been landed. Closing PR #47190 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c4a44e4 into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
@whsieh whsieh deleted the eng/294980 branch June 25, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants