Skip to content

Headroom trait changes are not forwarded to WebProcessPool on iOS #47189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

Headroom trait changes are not forwarded to WebProcessPool on iOS #47189

merged 1 commit into from
Jun 26, 2025
+20 −4

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

3fcc3d4

Headroom trait changes are not forwarded to WebProcessPool on iOS
https://bugs.webkit.org/show_bug.cgi?id=294979
radar://154305310

Reviewed by Said Abou-Hallawa.

iOS doesn't send the NSApp* notification changes, instead it
listens for trait changes on the WebView.

When this changes we need to execute the same logic macOS
runs when receiving the app-wide notification.

* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::suppressEDR):
Track state so we only run the logic once per trait change
similar to macOS.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setShouldSuppressHDR):
* Source/WebKit/UIProcess/WebProcessPool.h:

Canonical link: https://commits.webkit.org/296657@main

6d76966

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski requested a review from cdumez as a code owner June 25, 2025 17:01
@mwyrzykowski mwyrzykowski self-assigned this Jun 25, 2025
@mwyrzykowski mwyrzykowski added the Layout and Rendering For bugs with layout and rendering of Web pages. label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 7297038)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

shallawa
shallawa approved these changes Jun 25, 2025
View reviewed changes
@mwyrzykowski mwyrzykowski force-pushed the eng/Headroom-trait-changes-are-not-forwarded-to-WebProcessPool-on-iOS branch from 7297038 to 6d76966 Compare June 25, 2025 22:39
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 6d76966)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 25, 2025
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jun 26, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #61454.

@mwyrzykowski
Headroom trait changes are not forwarded to WebProcessPool on iOS
3fcc3d4 
https://bugs.webkit.org/show_bug.cgi?id=294979
radar://154305310

Reviewed by Said Abou-Hallawa.

iOS doesn't send the NSApp* notification changes, instead it
listens for trait changes on the WebView.

When this changes we need to execute the same logic macOS
runs when receiving the app-wide notification.

* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::suppressEDR):
Track state so we only run the logic once per trait change
similar to macOS.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setShouldSuppressHDR):
* Source/WebKit/UIProcess/WebProcessPool.h:

Canonical link: https://commits.webkit.org/296657@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Headroom-trait-changes-are-not-forwarded-to-WebProcessPool-on-iOS branch from 6d76966 to 3fcc3d4 Compare June 26, 2025 09:49
@webkit-commit-queue
Copy link
Collaborator

Committed 296657@main (3fcc3d4): https://commits.webkit.org/296657@main

Reviewed commits have been landed. Closing PR #47189 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3fcc3d4 into WebKit:main Jun 26, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shallawa shallawa shallawa approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@mattwoodrow mattwoodrow Awaiting requested review from mattwoodrow

@squelart squelart Awaiting requested review from squelart

Assignees

@mwyrzykowski mwyrzykowski

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mwyrzykowski @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @shallawa