Skip to content

Remove respondsToSelector from ApplePaySetupFeature #47184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Remove respondsToSelector from ApplePaySetupFeature #47184

merged 1 commit into from
Jun 25, 2025
+5 −23

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

2b981ab

Remove respondsToSelector from ApplePaySetupFeature
https://bugs.webkit.org/show_bug.cgi?id=294972

Reviewed by Andy Estes.

This mostly reverts 226869@main now we are far enough in the future.

Canonical link: https://commits.webkit.org/296621@main

e1be1c3

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk requested a review from aprotyas as a code owner June 25, 2025 13:40
@annevk annevk self-assigned this Jun 25, 2025
@annevk annevk added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash e1be1c3)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk requested a review from aestes June 25, 2025 13:42
@annevk annevk added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jun 25, 2025
@annevk
Remove respondsToSelector from ApplePaySetupFeature
2b981ab 
https://bugs.webkit.org/show_bug.cgi?id=294972

Reviewed by Andy Estes.

This mostly reverts 226869@main now we are far enough in the future.

Canonical link: https://commits.webkit.org/296621@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-respondsToSelector-from-ApplePaySetupFeature branch from e1be1c3 to 2b981ab Compare June 25, 2025 16:21
@webkit-commit-queue
Copy link
Collaborator

Committed 296621@main (2b981ab): https://commits.webkit.org/296621@main

Reviewed commits have been landed. Closing PR #47184 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2b981ab into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jun 25, 2025
@annevk annevk deleted the eng/Remove-respondsToSelector-from-ApplePaySetupFeature branch June 25, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aestes aestes aestes approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas aprotyas is a code owner

Assignees

@annevk annevk

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annevk @webkit-early-warning-system @webkit-commit-queue @aestes