Skip to content

Remove respondsToSelector for AVOutputContext #47181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Remove respondsToSelector for AVOutputContext #47181

merged 1 commit into from
Jun 27, 2025

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

0e4b984

Remove respondsToSelector for AVOutputContext
https://bugs.webkit.org/show_bug.cgi?id=294969

Reviewed by Eric Carlson.

ENABLE_WIRELESS_PLAYBACK_TARGET is true for all of Cocoa.
sharedAudioPresentationOutputContext, supportsMultipleOutputDevices,
outputDevices, and outputDevice are supported across all Cocoa SDKs
allowing us to simplify our code.

Canonical link: https://commits.webkit.org/296723@main

9faabfb

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk self-assigned this Jun 25, 2025
@annevk annevk added the Media Bugs related to the HTML 5 Media elements. label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 9faabfb)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk requested review from jyavenard and eric-carlson June 25, 2025 14:54
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 25, 2025
@annevk annevk removed the merging-blocked Applied to prevent a change from being merged label Jun 27, 2025
@annevk annevk added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 27, 2025
@annevk
Remove respondsToSelector for AVOutputContext
0e4b984 
https://bugs.webkit.org/show_bug.cgi?id=294969

Reviewed by Eric Carlson.

ENABLE_WIRELESS_PLAYBACK_TARGET is true for all of Cocoa.
sharedAudioPresentationOutputContext, supportsMultipleOutputDevices,
outputDevices, and outputDevice are supported across all Cocoa SDKs
allowing us to simplify our code.

Canonical link: https://commits.webkit.org/296723@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-respondsToSelector-for-AVOutputContext branch from 9faabfb to 0e4b984 Compare June 27, 2025 13:05
@webkit-commit-queue
Copy link
Collaborator

Committed 296723@main (0e4b984): https://commits.webkit.org/296723@main

Reviewed commits have been landed. Closing PR #47181 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0e4b984 into WebKit:main Jun 27, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 27, 2025
@annevk annevk deleted the eng/Remove-respondsToSelector-for-AVOutputContext branch June 27, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyavenard jyavenard jyavenard approved these changes

@eric-carlson eric-carlson eric-carlson approved these changes

Assignees

@annevk annevk

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@annevk @webkit-early-warning-system @webkit-commit-queue @jyavenard @eric-carlson @webkit-ews-buildbot