-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Reduce unsafeness in PDF and assorted code #47174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce unsafeness in PDF and assorted code #47174
Conversation
EWS run on previous version of this PR (hash 859392c) |
Safer C++ Build #41529 (859392c)
|
@@ -71,7 +71,7 @@ | |||
return m_plugin.get(); | |||
} | |||
|
|||
PageOverlay& PDFDataDetectorOverlayController::installOverlayIfNeeded() | |||
Ref<PageOverlay> PDFDataDetectorOverlayController::installProtectedOverlayIfNeeded() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which is this returning a Ref<>
? We are not transferring ownership. This doesn't not look like a step in the right direction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also make the protected variant wrap the non-protected variant, but I thought that if there's only one caller that might be a bit redundant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you added protected
in the name! I missed that during review. This is fine then.
859392c
to
4bf284a
Compare
EWS run on previous version of this PR (hash 4bf284a) |
Safer C++ Build #41792 (4bf284a)❌ Found 1 failing file with 4 issues. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. |
4bf284a
to
259ed3d
Compare
EWS run on current version of this PR (hash 259ed3d) |
https://bugs.webkit.org/show_bug.cgi?id=294960 Reviewed by Charlie Wolfe. Apply https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines Canonical link: https://commits.webkit.org/296716@main
259ed3d
to
e50830e
Compare
Committed 296716@main (e50830e): https://commits.webkit.org/296716@main Reviewed commits have been landed. Closing PR #47174 and removing active labels. |
e50830e
259ed3d