Skip to content

Whitespace incorrectly suppressed inside table. #47169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Whitespace incorrectly suppressed inside table. #47169

wants to merge 1 commit into from

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

3095539

Whitespace incorrectly suppressed inside table.
https://bugs.webkit.org/show_bug.cgi?id=251178
rdar://104934417

Reviewed by NOBODY (OOPS!).

This fixes an issue where blink and webkit ignores the whitespace text
nodes in tables against what the specification is saying. See the issue
w3c/csswg-drafts#8358

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/the-innertext-and-outertext-properties/getter-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-mozilla-162063-expected.txt:
* LayoutTests/platform/mac/fast/css-generated-content/015-expected.txt:
* LayoutTests/platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt:
* LayoutTests/platform/mac/fast/table/table-after-child-in-table-expected.txt:
* LayoutTests/platform/mac/fast/table/table-before-child-in-table-expected.txt:
* LayoutTests/platform/mac/fast/table/table-cell-after-child-in-table-expected.txt:
* LayoutTests/platform/mac/fast/table/table-cell-before-child-in-table-expected.txt:
* LayoutTests/platform/mac/fast/table/table-row-after-child-in-table-expected.txt:
* LayoutTests/platform/mac/fast/table/table-row-before-child-in-table-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::textRendererIsNeeded):

3095539

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@karlcow karlcow self-assigned this Jun 25, 2025
@karlcow karlcow added the Layout and Rendering For bugs with layout and rendering of Web pages. label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 1675e55)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@karlcow karlcow requested a review from alanbaradlay June 25, 2025 06:29
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 25, 2025
@karlcow
Whitespace incorrectly suppressed inside table.
3095539 
https://bugs.webkit.org/show_bug.cgi?id=251178
rdar://104934417

Reviewed by NOBODY (OOPS!).

This fixes an issue where blink and webkit ignores the whitespace text
nodes in tables against what the specification is saying. See the issue
w3c/csswg-drafts#8358

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/the-innertext-and-outertext-properties/getter-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-mozilla-162063-expected.txt:
* LayoutTests/platform/mac/fast/css-generated-content/015-expected.txt:
* LayoutTests/platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt:
* LayoutTests/platform/mac/fast/table/table-after-child-in-table-expected.txt:
* LayoutTests/platform/mac/fast/table/table-before-child-in-table-expected.txt:
* LayoutTests/platform/mac/fast/table/table-cell-after-child-in-table-expected.txt:
* LayoutTests/platform/mac/fast/table/table-cell-before-child-in-table-expected.txt:
* LayoutTests/platform/mac/fast/table/table-row-after-child-in-table-expected.txt:
* LayoutTests/platform/mac/fast/table/table-row-before-child-in-table-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::textRendererIsNeeded):
@karlcow karlcow removed the merging-blocked Applied to prevent a change from being merged label Jun 25, 2025
@karlcow karlcow force-pushed the 251178-table-whitespace branch from 1675e55 to 3095539 Compare June 25, 2025 08:48
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 3095539)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 25, 2025
@karlcow
Copy link
Member Author

karlcow commented Jun 25, 2025 

imported/blink/fast/table/whitespace-between-elements-with-table-cell-display-2.html
imported/blink/fast/table/whitespace-between-elements-with-table-cell-display-3.html
imported/blink/fast/table/whitespace-between-elements-with-table-cell-display.html

These 3 tests are being broken by this change, while Firefox is still behaving the same. The progression creates regression for form elements inside table elements. So something to figure out.

@karlcow
Copy link
Member Author

karlcow commented Jun 25, 2025

It also creates interesting regression for
http://wpt.live/css/css-text/white-space/ws-break-spaces-applies-to-006.html

Screenshot 2025-06-26 at 07 14 33

@karlcow
Copy link
Member Author

karlcow commented Jun 25, 2025

Also http://wpt.live/css/css-display/display-contents-dynamic-table-002-inline.html
Screenshot 2025-06-26 at 07 19 00

@karlcow
Copy link
Member Author

karlcow commented Jun 26, 2025 

imported/blink/fast/table/whitespace-between-elements-with-table-cell-display-3.html
Screenshot 2025-06-26 at 16 43 58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanbaradlay alanbaradlay Awaiting requested review from alanbaradlay

Assignees

@karlcow karlcow

Labels
Layout and Rendering For bugs with layout and rendering of Web pages. merging-blocked Applied to prevent a change from being merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karlcow @webkit-early-warning-system @webkit-ews-buildbot