Skip to content

[visionOS] Gaze glow shape is incorrect for elements with associated label and non-uniform border radii or clip path #47168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

[visionOS] Gaze glow shape is incorrect for elements with associated label and non-uniform border radii or clip path #47168

merged 1 commit into from
Jun 26, 2025

Conversation

lilyspiniolas
Copy link
Contributor

@lilyspiniolas lilyspiniolas commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

b1e40d1

[visionOS] Gaze glow shape is incorrect for elements with associated label and non-uniform border radii or clip path
https://bugs.webkit.org/show_bug.cgi?id=294952
rdar://154258426

Reviewed by Abrar Rahman Protyasha.

During the shrink wrapping of interaction regions, we previously
collected the rect of each discovered region, and then set the
clip path equal to the result of `pathWithShrinkWrappedRects`
with the collected rects passed as a parameter.

Now, for each discovered region, we only add its rect to the
collection if the region does not have a clip path. If a clip
path is present, we add it a collection of clip paths. The
final clip path is then set to a path consisting of all of the
discovered clip paths + the result of `pathWithShrinkWrappedRect`
for the collected rects.

* LayoutTests/interaction-region/clip-path-with-label-expected.txt: Added.
* LayoutTests/interaction-region/clip-path-with-label.html: Added.
* Source/WebCore/rendering/EventRegion.cpp:
(WebCore::EventRegionContext::shrinkWrapInteractionRegions):

Canonical link: https://commits.webkit.org/296646@main

5685983

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@lilyspiniolas lilyspiniolas self-assigned this Jun 25, 2025
@lilyspiniolas lilyspiniolas added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on previous version of this PR (hash c8fbb2f)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pxlcoder
Copy link
Member

This should be testable, or maybe need a rebaseline somewhere.

See LayoutTests/interaction-region/labels.html for inspiration.

aprotyas
aprotyas reviewed Jun 25, 2025
View reviewed changes
@etiennesegonzac
Copy link
Contributor

This should be testable, or maybe need a rebaseline somewhere.

See LayoutTests/interaction-region/labels.html for inspiration.

Yes please!
These tests are vision-only but I'm happy to help!

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 62474b9)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win
✅ 🧪 bindings loading 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl loading 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
loading 🧪 ios-wk2-wpt   🧪 mac-wk1 ⏳ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2 ⏳ 🛠 playstation
✅ 🛠 tv ⏳ 🛠 mac-safer-cpp
⏳ 🛠 tv-sim
⏳ 🛠 watch
⏳ 🛠 watch-sim

@lilyspiniolas
Copy link
Contributor Author

Added tests 😄 @pxlcoder @etiennesegonzac

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 276b380)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac   🛠 wpe ⏳ 🛠 win
  🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ⏳ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2 ⏳ 🛠 playstation
⏳ 🛠 tv ⏳ 🛠 mac-safer-cpp
⏳ 🛠 tv-sim
⏳ 🛠 watch
⏳ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 5685983)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@lilyspiniolas lilyspiniolas added the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2025
@lilyspiniolas
[visionOS] Gaze glow shape is incorrect for elements with associated …
b1e40d1 
…label and non-uniform border radii or clip path

https://bugs.webkit.org/show_bug.cgi?id=294952
rdar://154258426

Reviewed by Abrar Rahman Protyasha.

During the shrink wrapping of interaction regions, we previously
collected the rect of each discovered region, and then set the
clip path equal to the result of `pathWithShrinkWrappedRects`
with the collected rects passed as a parameter.

Now, for each discovered region, we only add its rect to the
collection if the region does not have a clip path. If a clip
path is present, we add it a collection of clip paths. The
final clip path is then set to a path consisting of all of the
discovered clip paths + the result of `pathWithShrinkWrappedRect`
for the collected rects.

* LayoutTests/interaction-region/clip-path-with-label-expected.txt: Added.
* LayoutTests/interaction-region/clip-path-with-label.html: Added.
* Source/WebCore/rendering/EventRegion.cpp:
(WebCore::EventRegionContext::shrinkWrapInteractionRegions):

Canonical link: https://commits.webkit.org/296646@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296646@main (b1e40d1): https://commits.webkit.org/296646@main

Reviewed commits have been landed. Closing PR #47168 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b1e40d1 into WebKit:main Jun 26, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprotyas aprotyas aprotyas approved these changes

@etiennesegonzac etiennesegonzac Awaiting requested review from etiennesegonzac

@hortont424 hortont424 Awaiting requested review from hortont424

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

Assignees

@lilyspiniolas lilyspiniolas

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lilyspiniolas @webkit-early-warning-system @pxlcoder @etiennesegonzac @webkit-commit-queue @aprotyas