Skip to content

Reduce scope of WTF_ALLOW_UNSAFE_BUFFER_USAGE macros in wtf/text #47163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Reduce scope of WTF_ALLOW_UNSAFE_BUFFER_USAGE macros in wtf/text #47163

merged 1 commit into from
Jun 25, 2025

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

7befcc5

Reduce scope of WTF_ALLOW_UNSAFE_BUFFER_USAGE macros in wtf/text
https://bugs.webkit.org/show_bug.cgi?id=294953

Reviewed by Darin Adler.

* Source/WTF/wtf/text/AdaptiveStringSearcher.h:
* Source/WTF/wtf/text/StringHasherInlines.h:
(WTF::StringHasher::computeLiteralHashAndMaskTop8Bits):
(WTF::StringHasher::addCharacter):
(WTF::StringHasher::hashWithTop8BitsMasked):
* Source/WTF/wtf/text/SuperFastHash.h:
* Source/WTF/wtf/text/WTFString.h:
(WTF::StringLiterals::operator_str):

Canonical link: https://commits.webkit.org/296624@main

9e9f987

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ❌ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 9e9f987)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ❌ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez marked this pull request as ready for review June 25, 2025 14:46
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
@cdumez
Reduce scope of WTF_ALLOW_UNSAFE_BUFFER_USAGE macros in wtf/text
7befcc5 
https://bugs.webkit.org/show_bug.cgi?id=294953

Reviewed by Darin Adler.

* Source/WTF/wtf/text/AdaptiveStringSearcher.h:
* Source/WTF/wtf/text/StringHasherInlines.h:
(WTF::StringHasher::computeLiteralHashAndMaskTop8Bits):
(WTF::StringHasher::addCharacter):
(WTF::StringHasher::hashWithTop8BitsMasked):
* Source/WTF/wtf/text/SuperFastHash.h:
* Source/WTF/wtf/text/WTFString.h:
(WTF::StringLiterals::operator_str):

Canonical link: https://commits.webkit.org/296624@main
@webkit-commit-queue webkit-commit-queue force-pushed the 294953_wtf_text_safe_buffers branch from 9e9f987 to 7befcc5 Compare June 25, 2025 16:52
@webkit-commit-queue
Copy link
Collaborator

Committed 296624@main (7befcc5): https://commits.webkit.org/296624@main

Reviewed commits have been landed. Closing PR #47163 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7befcc5 into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

@ddkilzer ddkilzer Awaiting requested review from ddkilzer

@rniwa rniwa Awaiting requested review from rniwa

Assignees

@cdumez cdumez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler