Skip to content

[JSC] Fold MakeRope's constant part more #47158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

[JSC] Fold MakeRope's constant part more #47158

merged 1 commit into from
Jun 26, 2025
+56 −16

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

b4e75f7

[JSC] Fold MakeRope's constant part more
https://bugs.webkit.org/show_bug.cgi?id=294947
rdar://154254102

Reviewed by Yijia Huang.

Let's fold some part of MakeRope like,

    MakeRope(constant, constant, value) => MakeRope(constant, value)
    MakeRope(value, constant, constant) => MakeRope(value, constant)
    MakeRope(constant) => constant

* Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):

Canonical link: https://commits.webkit.org/296662@main

2aa2a3c

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ❌ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@Constellation Constellation requested a review from a team as a code owner June 25, 2025 03:09
@Constellation Constellation self-assigned this Jun 25, 2025
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 2aa2a3c)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ❌ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

hyjorc1
hyjorc1 approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@hyjorc1 hyjorc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, we can add this to the commit message for better clarity.

This folds adjacent constant strings to reduce rope depth, simplify the IR, and improve runtime performance by avoiding unnecessary string concatenation.

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Fold-MakeRope-s-constant-part-more branch from 2aa2a3c to fcacd3b Compare June 26, 2025 13:55
@Constellation
[JSC] Fold MakeRope's constant part more
b4e75f7 
https://bugs.webkit.org/show_bug.cgi?id=294947
rdar://154254102

Reviewed by Yijia Huang.

Let's fold some part of MakeRope like,

    MakeRope(constant, constant, value) => MakeRope(constant, value)
    MakeRope(value, constant, constant) => MakeRope(value, constant)
    MakeRope(constant) => constant

* Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):

Canonical link: https://commits.webkit.org/296662@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Fold-MakeRope-s-constant-part-more branch from fcacd3b to b4e75f7 Compare June 26, 2025 13:57
@webkit-commit-queue
Copy link
Collaborator

Committed 296662@main (b4e75f7): https://commits.webkit.org/296662@main

Reviewed commits have been landed. Closing PR #47158 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b4e75f7 into WebKit:main Jun 26, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyjorc1 hyjorc1 hyjorc1 approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @hyjorc1