Skip to content

TestWebKitAPI.WKScrollGeometry.ContentSizeTallerThanWebView is a constant failure on macOS Sequoia and iPadOS #47155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

TestWebKitAPI.WKScrollGeometry.ContentSizeTallerThanWebView is a constant failure on macOS Sequoia and iPadOS #47155

merged 1 commit into from
Jun 25, 2025

Conversation

pxlcoder
Copy link
Member

@pxlcoder pxlcoder commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

0621846

TestWebKitAPI.WKScrollGeometry.ContentSizeTallerThanWebView is a constant failure on macOS Sequoia and iPadOS
https://bugs.webkit.org/show_bug.cgi?id=294915
rdar://154213450

Reviewed by Wenson Hsieh.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKScrollGeometryTests.mm:
(TEST(WKScrollGeometry, ContentSizeTallerThanWebView)):

Adjust the macOS platform conditional to reflect that the scrollbar size on
macOS Sequoia matches the size on macOS Tahoe, not macOS Sonoma.

Add a viewport meta tag to ensure a consistent width on iOS and iPadOS.

Canonical link: https://commits.webkit.org/296604@main

444bddb

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pxlcoder pxlcoder self-assigned this Jun 25, 2025
@pxlcoder pxlcoder added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 444bddb)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pxlcoder pxlcoder added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 25, 2025
@pxlcoder
TestWebKitAPI.WKScrollGeometry.ContentSizeTallerThanWebView is a cons…
0621846 
…tant failure on macOS Sequoia and iPadOS

https://bugs.webkit.org/show_bug.cgi?id=294915
rdar://154213450

Reviewed by Wenson Hsieh.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKScrollGeometryTests.mm:
(TEST(WKScrollGeometry, ContentSizeTallerThanWebView)):

Adjust the macOS platform conditional to reflect that the scrollbar size on
macOS Sequoia matches the size on macOS Tahoe, not macOS Sonoma.

Add a viewport meta tag to ensure a consistent width on iOS and iPadOS.

Canonical link: https://commits.webkit.org/296604@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296604@main (0621846): https://commits.webkit.org/296604@main

Reviewed commits have been landed. Closing PR #47155 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0621846 into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

@hortont424 hortont424 Awaiting requested review from hortont424

@rr-codes rr-codes Awaiting requested review from rr-codes

@aprotyas aprotyas Awaiting requested review from aprotyas

@megangardner megangardner Awaiting requested review from megangardner

@jesxilin jesxilin Awaiting requested review from jesxilin

@lilyspiniolas lilyspiniolas Awaiting requested review from lilyspiniolas

Assignees

@pxlcoder pxlcoder

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pxlcoder @webkit-early-warning-system @webkit-commit-queue @whsieh