Skip to content

[WebGPU] Move GPUAdapter isFallbackAdapter attribute to GPUAdapterInfo #47152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

[WebGPU] Move GPUAdapter isFallbackAdapter attribute to GPUAdapterInfo #47152

merged 1 commit into from
Jul 1, 2025
+2 −0

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

c7c76cf

[WebGPU] Move GPUAdapter isFallbackAdapter attribute to GPUAdapterInfo
https://bugs.webkit.org/show_bug.cgi?id=290362
rdar://147800092

Reviewed by Tadeu Zagallo.

The spec deprecated this in March and is removing it
from GPUAdapter, but we don't want to break any clients,
so just add it in the new place for now.

We never create a fallback adapter, so we can always
return false.

* Source/WebCore/Modules/WebGPU/GPUAdapterInfo.h:
(WebCore::GPUAdapterInfo::isFallbackAdapter const):
* Source/WebCore/Modules/WebGPU/GPUAdapterInfo.idl:

Canonical link: https://commits.webkit.org/296879@main

b7024db

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Jun 25, 2025
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on previous version of this PR (hash a5b8269)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 win
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🛠 wpe-cairo
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🛠 gtk
❌ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
❌ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
⏳ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ❌ 🛠 playstation
❌ 🛠 tv ❌ 🛠 mac-safer-cpp
❌ 🛠 tv-sim
❌ 🛠 watch
❌ 🛠 watch-sim

@mwyrzykowski mwyrzykowski mentioned this pull request Jun 25, 2025
Merged
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 25, 2025
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label Jun 25, 2025
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-Move-GPUAdapter-isFallbackAdapter-attribute-to-GPUAdapterInfo branch from a5b8269 to b7024db Compare June 25, 2025 06:17
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash b7024db)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Jul 1, 2025
@mwyrzykowski
[WebGPU] Move GPUAdapter isFallbackAdapter attribute to GPUAdapterInfo
c7c76cf 
https://bugs.webkit.org/show_bug.cgi?id=290362
rdar://147800092

Reviewed by Tadeu Zagallo.

The spec deprecated this in March and is removing it
from GPUAdapter, but we don't want to break any clients,
so just add it in the new place for now.

We never create a fallback adapter, so we can always
return false.

* Source/WebCore/Modules/WebGPU/GPUAdapterInfo.h:
(WebCore::GPUAdapterInfo::isFallbackAdapter const):
* Source/WebCore/Modules/WebGPU/GPUAdapterInfo.idl:

Canonical link: https://commits.webkit.org/296879@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-Move-GPUAdapter-isFallbackAdapter-attribute-to-GPUAdapterInfo branch from b7024db to c7c76cf Compare July 1, 2025 19:06
@webkit-commit-queue
Copy link
Collaborator

Committed 296879@main (c7c76cf): https://commits.webkit.org/296879@main

Reviewed commits have been landed. Closing PR #47152 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c7c76cf into WebKit:main Jul 1, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeuzagallo tadeuzagallo tadeuzagallo approved these changes

Assignees

@mwyrzykowski mwyrzykowski

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mwyrzykowski @webkit-early-warning-system @webkit-commit-queue @tadeuzagallo @webkit-ews-buildbot