-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Rework grid-self-baseline-two-dimensional test. #47151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
sammygill:rework-grid-self-baseline-two-dimensional
Jun 25, 2025
Merged
Rework grid-self-baseline-two-dimensional test. #47151
webkit-commit-queue
merged 1 commit into
WebKit:main
from
sammygill:rework-grid-self-baseline-two-dimensional
Jun 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash c97d752) |
c97d752
to
6b22f08
Compare
EWS run on previous version of this PR (hash 6b22f08) |
6b22f08
to
a72b2d8
Compare
EWS run on current version of this PR (hash a72b2d8) |
alanbaradlay
approved these changes
Jun 25, 2025
Andrew-Fryer
approved these changes
Jun 25, 2025
https://bugs.webkit.org/show_bug.cgi?id=294943 rdar://problem/154246114 Reviewed by Alan Baradlay. This test was imported from Blink as part of 206316@main. Since then, there have been some discussions regarding how baseline alignment works is a variety of scenarios such as orthogonal content and in particular content that needs to synthesize a baseline. Blink ended up adopting this behavior in: https://chromium-review.googlesource.com/c/chromium/src/+/3916247 As part of that change they also updated a variety of WPTs to reflect this new behavior and also deleted this test from their repo. In this patch I do two main things: 1.) Move this test over to WPT. For the most part this is just moving the test to the correct location and linking to the correct WPT infrastructure rather than the copies we had locally. I also adjusted the font sizes to follow the recommendations in: https://web-platform-tests.org/writing-tests/ahem.html which is just using the font shorthand and making sure the size is a multiple of 5px. 2.) Update the expectations to reflect this new behavior. Canonical link: https://commits.webkit.org/296619@main
a72b2d8
to
2f8f45d
Compare
Committed 296619@main (2f8f45d): https://commits.webkit.org/296619@main Reviewed commits have been landed. Closing PR #47151 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Tools / Tests
Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2f8f45d
a72b2d8