Skip to content

Rework grid-self-baseline-two-dimensional test. #47151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sammygill
Copy link
Contributor

@sammygill sammygill commented Jun 25, 2025

2f8f45d

Rework grid-self-baseline-two-dimensional test.
https://bugs.webkit.org/show_bug.cgi?id=294943
rdar://problem/154246114

Reviewed by Alan Baradlay.

This test was imported from Blink as part of 206316@main. Since then,
there have been some discussions regarding how baseline alignment works
is a variety of scenarios such as orthogonal content and in particular
content that needs to synthesize a baseline. Blink ended up adopting
this behavior in:
https://chromium-review.googlesource.com/c/chromium/src/+/3916247

As part of that change they also updated a variety of WPTs to reflect
this new behavior and also deleted this test from their repo. In this
patch I do two main things:

1.) Move this test over to WPT. For the most part this is just moving
the test to the correct location and linking to the correct WPT
infrastructure rather than the copies we had locally. I also adjusted
the font sizes to follow the recommendations in:

https://web-platform-tests.org/writing-tests/ahem.html

which is just using the font shorthand and making sure the size is a
multiple of 5px.

2.) Update the expectations to reflect this new behavior.

Canonical link: https://commits.webkit.org/296619@main

a72b2d8

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@sammygill sammygill self-assigned this Jun 25, 2025
@sammygill sammygill added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 25, 2025
@sammygill sammygill force-pushed the rework-grid-self-baseline-two-dimensional branch from c97d752 to 6b22f08 Compare June 25, 2025 01:30
@sammygill sammygill force-pushed the rework-grid-self-baseline-two-dimensional branch from 6b22f08 to a72b2d8 Compare June 25, 2025 01:32
@sammygill sammygill added the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
https://bugs.webkit.org/show_bug.cgi?id=294943
rdar://problem/154246114

Reviewed by Alan Baradlay.

This test was imported from Blink as part of 206316@main. Since then,
there have been some discussions regarding how baseline alignment works
is a variety of scenarios such as orthogonal content and in particular
content that needs to synthesize a baseline. Blink ended up adopting
this behavior in:
https://chromium-review.googlesource.com/c/chromium/src/+/3916247

As part of that change they also updated a variety of WPTs to reflect
this new behavior and also deleted this test from their repo. In this
patch I do two main things:

1.) Move this test over to WPT. For the most part this is just moving
the test to the correct location and linking to the correct WPT
infrastructure rather than the copies we had locally. I also adjusted
the font sizes to follow the recommendations in:

https://web-platform-tests.org/writing-tests/ahem.html

which is just using the font shorthand and making sure the size is a
multiple of 5px.

2.) Update the expectations to reflect this new behavior.

Canonical link: https://commits.webkit.org/296619@main
@webkit-commit-queue webkit-commit-queue force-pushed the rework-grid-self-baseline-two-dimensional branch from a72b2d8 to 2f8f45d Compare June 25, 2025 14:54
@webkit-commit-queue
Copy link
Collaborator

Committed 296619@main (2f8f45d): https://commits.webkit.org/296619@main

Reviewed commits have been landed. Closing PR #47151 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2f8f45d into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants