Skip to content

[SaferCPP] Improve smart pointer adoption in the UIProcess C API, part 2 #47149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zakariaridouh
Copy link
Contributor

@zakariaridouh zakariaridouh commented Jun 25, 2025

cebb5de

[SaferCPP] Improve smart pointer adoption in the UIProcess C API, part 2
https://bugs.webkit.org/show_bug.cgi?id=294941
rdar://154244293

Reviewed by Charlie Wolfe.

Fix many failing smart pointer adoption errors caught by static analyses, in the following files.

    - UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp
    - UIProcess/API/C/WKSpeechRecognitionPermissionCallback.cpp
    - UIProcess/API/C/WKQueryPermissionResultCallback.cpp
    - UIProcess/API/C/WKFormSubmissionListener.cpp
    - UIProcess/API/C/WKContextConfigurationRef.cpp
    - UIProcess/API/C/WKBackForwardListRef.cpp
    - UIProcess/API/C/WKAuthenticationChallenge.cpp

Getting closer to being done with the UIP C API. =)

* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/UIProcess/API/C/WKAuthenticationChallenge.cpp:
(WKAuthenticationChallengeGetProtectionSpace):
(WKAuthenticationChallengeGetProposedCredential):
* Source/WebKit/UIProcess/API/C/WKBackForwardListRef.cpp:
(WKBackForwardListGetCurrentItem):
(WKBackForwardListGetBackItem):
(WKBackForwardListGetForwardItem):
(WKBackForwardListGetItemAtIndex):
* Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp:
(WKContextConfigurationSetInjectedBundlePath):
(WKContextConfigurationSetOverrideLanguages):
(WKContextConfigurationSetTimeZoneOverride):
* Source/WebKit/UIProcess/API/C/WKFormSubmissionListener.cpp:
(WKFormSubmissionListenerContinue):
* Source/WebKit/UIProcess/API/C/WKQueryPermissionResultCallback.cpp:
(WKQueryPermissionResultCallbackCompleteWithDenied):
(WKQueryPermissionResultCallbackCompleteWithGranted):
(WKQueryPermissionResultCallbackCompleteWithPrompt):
* Source/WebKit/UIProcess/API/C/WKSpeechRecognitionPermissionCallback.cpp:
(WKSpeechRecognitionPermissionCallbackComplete):
* Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp:
(WKWebsiteDataStoreConfigurationSetApplicationCacheDirectory):
(WKWebsiteDataStoreConfigurationSetNetworkCacheDirectory):
(WKWebsiteDataStoreConfigurationSetIndexedDBDatabaseDirectory):
(WKWebsiteDataStoreConfigurationSetLocalStorageDirectory):
(WKWebsiteDataStoreConfigurationSetWebSQLDatabaseDirectory):
(WKWebsiteDataStoreConfigurationSetCacheStorageDirectory):
(WKWebsiteDataStoreConfigurationSetGeneralStorageDirectory):
(WKWebsiteDataStoreConfigurationSetMediaKeysStorageDirectory):
(WKWebsiteDataStoreConfigurationSetResourceLoadStatisticsDirectory):
(WKWebsiteDataStoreConfigurationSetServiceWorkerRegistrationDirectory):
(WKWebsiteDataStoreConfigurationSetCookieStorageFile):
(WKWebsiteDataStoreConfigurationSetPCMMachServiceName):
(WKWebsiteDataStoreConfigurationSetResourceMonitorThrottlerDirectory):
* Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::protectedProposedCredential const):
(WebKit::AuthenticationChallengeProxy::protectedProtectionSpace const):
* Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h:

Canonical link: https://commits.webkit.org/296642@main

d488145

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 🛠 playstation
✅ 🛠 tv 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@zakariaridouh zakariaridouh requested a review from cdumez as a code owner June 25, 2025 00:50
@zakariaridouh zakariaridouh self-assigned this Jun 25, 2025
@zakariaridouh zakariaridouh added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 25, 2025
@zakariaridouh zakariaridouh force-pushed the eng/SaferCPP-Improve-smart-pointer-adoption-in-the-UIProcess-C-API-part-2 branch from c0de3ff to 838f24e Compare June 25, 2025 22:11
@zakariaridouh zakariaridouh force-pushed the eng/SaferCPP-Improve-smart-pointer-adoption-in-the-UIProcess-C-API-part-2 branch from 838f24e to d488145 Compare June 26, 2025 00:34
@zakariaridouh zakariaridouh added the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2025
https://bugs.webkit.org/show_bug.cgi?id=294941
rdar://154244293

Reviewed by Charlie Wolfe.

Fix many failing smart pointer adoption errors caught by static analyses, in the following files.

    - UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp
    - UIProcess/API/C/WKSpeechRecognitionPermissionCallback.cpp
    - UIProcess/API/C/WKQueryPermissionResultCallback.cpp
    - UIProcess/API/C/WKFormSubmissionListener.cpp
    - UIProcess/API/C/WKContextConfigurationRef.cpp
    - UIProcess/API/C/WKBackForwardListRef.cpp
    - UIProcess/API/C/WKAuthenticationChallenge.cpp

Getting closer to being done with the UIP C API. =)

* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/UIProcess/API/C/WKAuthenticationChallenge.cpp:
(WKAuthenticationChallengeGetProtectionSpace):
(WKAuthenticationChallengeGetProposedCredential):
* Source/WebKit/UIProcess/API/C/WKBackForwardListRef.cpp:
(WKBackForwardListGetCurrentItem):
(WKBackForwardListGetBackItem):
(WKBackForwardListGetForwardItem):
(WKBackForwardListGetItemAtIndex):
* Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp:
(WKContextConfigurationSetInjectedBundlePath):
(WKContextConfigurationSetOverrideLanguages):
(WKContextConfigurationSetTimeZoneOverride):
* Source/WebKit/UIProcess/API/C/WKFormSubmissionListener.cpp:
(WKFormSubmissionListenerContinue):
* Source/WebKit/UIProcess/API/C/WKQueryPermissionResultCallback.cpp:
(WKQueryPermissionResultCallbackCompleteWithDenied):
(WKQueryPermissionResultCallbackCompleteWithGranted):
(WKQueryPermissionResultCallbackCompleteWithPrompt):
* Source/WebKit/UIProcess/API/C/WKSpeechRecognitionPermissionCallback.cpp:
(WKSpeechRecognitionPermissionCallbackComplete):
* Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp:
(WKWebsiteDataStoreConfigurationSetApplicationCacheDirectory):
(WKWebsiteDataStoreConfigurationSetNetworkCacheDirectory):
(WKWebsiteDataStoreConfigurationSetIndexedDBDatabaseDirectory):
(WKWebsiteDataStoreConfigurationSetLocalStorageDirectory):
(WKWebsiteDataStoreConfigurationSetWebSQLDatabaseDirectory):
(WKWebsiteDataStoreConfigurationSetCacheStorageDirectory):
(WKWebsiteDataStoreConfigurationSetGeneralStorageDirectory):
(WKWebsiteDataStoreConfigurationSetMediaKeysStorageDirectory):
(WKWebsiteDataStoreConfigurationSetResourceLoadStatisticsDirectory):
(WKWebsiteDataStoreConfigurationSetServiceWorkerRegistrationDirectory):
(WKWebsiteDataStoreConfigurationSetCookieStorageFile):
(WKWebsiteDataStoreConfigurationSetPCMMachServiceName):
(WKWebsiteDataStoreConfigurationSetResourceMonitorThrottlerDirectory):
* Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::protectedProposedCredential const):
(WebKit::AuthenticationChallengeProxy::protectedProtectionSpace const):
* Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h:

Canonical link: https://commits.webkit.org/296642@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/SaferCPP-Improve-smart-pointer-adoption-in-the-UIProcess-C-API-part-2 branch from d488145 to cebb5de Compare June 26, 2025 01:10
@webkit-commit-queue
Copy link
Collaborator

Committed 296642@main (cebb5de): https://commits.webkit.org/296642@main

Reviewed commits have been landed. Closing PR #47149 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cebb5de into WebKit:main Jun 26, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants