-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[SaferCPP] Improve smart pointer adoption in the UIProcess C API, part 2 #47149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
zakariaridouh:eng/SaferCPP-Improve-smart-pointer-adoption-in-the-UIProcess-C-API-part-2
Jun 26, 2025
Merged
[SaferCPP] Improve smart pointer adoption in the UIProcess C API, part 2 #47149
webkit-commit-queue
merged 1 commit into
WebKit:main
from
zakariaridouh:eng/SaferCPP-Improve-smart-pointer-adoption-in-the-UIProcess-C-API-part-2
Jun 26, 2025
+46
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash c0de3ff) |
charliewolfe
approved these changes
Jun 25, 2025
c0de3ff
to
838f24e
Compare
EWS run on previous version of this PR (hash 838f24e) |
838f24e
to
d488145
Compare
EWS run on current version of this PR (hash d488145) |
https://bugs.webkit.org/show_bug.cgi?id=294941 rdar://154244293 Reviewed by Charlie Wolfe. Fix many failing smart pointer adoption errors caught by static analyses, in the following files. - UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp - UIProcess/API/C/WKSpeechRecognitionPermissionCallback.cpp - UIProcess/API/C/WKQueryPermissionResultCallback.cpp - UIProcess/API/C/WKFormSubmissionListener.cpp - UIProcess/API/C/WKContextConfigurationRef.cpp - UIProcess/API/C/WKBackForwardListRef.cpp - UIProcess/API/C/WKAuthenticationChallenge.cpp Getting closer to being done with the UIP C API. =) * Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: * Source/WebKit/UIProcess/API/C/WKAuthenticationChallenge.cpp: (WKAuthenticationChallengeGetProtectionSpace): (WKAuthenticationChallengeGetProposedCredential): * Source/WebKit/UIProcess/API/C/WKBackForwardListRef.cpp: (WKBackForwardListGetCurrentItem): (WKBackForwardListGetBackItem): (WKBackForwardListGetForwardItem): (WKBackForwardListGetItemAtIndex): * Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.cpp: (WKContextConfigurationSetInjectedBundlePath): (WKContextConfigurationSetOverrideLanguages): (WKContextConfigurationSetTimeZoneOverride): * Source/WebKit/UIProcess/API/C/WKFormSubmissionListener.cpp: (WKFormSubmissionListenerContinue): * Source/WebKit/UIProcess/API/C/WKQueryPermissionResultCallback.cpp: (WKQueryPermissionResultCallbackCompleteWithDenied): (WKQueryPermissionResultCallbackCompleteWithGranted): (WKQueryPermissionResultCallbackCompleteWithPrompt): * Source/WebKit/UIProcess/API/C/WKSpeechRecognitionPermissionCallback.cpp: (WKSpeechRecognitionPermissionCallbackComplete): * Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp: (WKWebsiteDataStoreConfigurationSetApplicationCacheDirectory): (WKWebsiteDataStoreConfigurationSetNetworkCacheDirectory): (WKWebsiteDataStoreConfigurationSetIndexedDBDatabaseDirectory): (WKWebsiteDataStoreConfigurationSetLocalStorageDirectory): (WKWebsiteDataStoreConfigurationSetWebSQLDatabaseDirectory): (WKWebsiteDataStoreConfigurationSetCacheStorageDirectory): (WKWebsiteDataStoreConfigurationSetGeneralStorageDirectory): (WKWebsiteDataStoreConfigurationSetMediaKeysStorageDirectory): (WKWebsiteDataStoreConfigurationSetResourceLoadStatisticsDirectory): (WKWebsiteDataStoreConfigurationSetServiceWorkerRegistrationDirectory): (WKWebsiteDataStoreConfigurationSetCookieStorageFile): (WKWebsiteDataStoreConfigurationSetPCMMachServiceName): (WKWebsiteDataStoreConfigurationSetResourceMonitorThrottlerDirectory): * Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.cpp: (WebKit::AuthenticationChallengeProxy::protectedProposedCredential const): (WebKit::AuthenticationChallengeProxy::protectedProtectionSpace const): * Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h: Canonical link: https://commits.webkit.org/296642@main
d488145
to
cebb5de
Compare
Committed 296642@main (cebb5de): https://commits.webkit.org/296642@main Reviewed commits have been landed. Closing PR #47149 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cebb5de
d488145
🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 ios-wk2-wpt🛠 wpe-cairo🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 vision-wk2🛠 playstation🛠 mac-safer-cpp