Skip to content

Classification of test gardening commits should be standardized across services #47148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Classification of test gardening commits should be standardized across services #47148

wants to merge 1 commit into from

Conversation

briannafan
Copy link
Contributor

@briannafan briannafan commented Jun 25, 2025 •
edited by webkit-early-warning-system
Loading

247def1

Classification of test gardening commits should be standardized across services
https://bugs.webkit.org/show_bug.cgi?id=294940
rdar://150067500

Reviewed by NOBODY (OOPS!).

EWS (merge-queue) searches for “unreviewed test gardening” in the entire commit message.
This was added to commit classes but it should actually be a hard requirement.
This PR makes it so test gardening commits are required to have “unreviewed test gardening”
in the commit message to be classified as such.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit_classifier.py:
(CommitClassifier.CommitClass.__init__): Check for contents.
(CommitClassifier.CommitClass.__repr__): Update repr with contents and trailers.
(CommitClassifier.classify): Content matching in a commit message should be a hard requirement.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/classify_unittest.py:
(TestClassify.test_path_no_repository):
(TestClassify):
(TestClassify.test_content_success):
(TestClassify.test_content_failure):

247def1

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🧪 services ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@briannafan
Classification of test gardening commits should be standardized acros…
247def1 
…s services

https://bugs.webkit.org/show_bug.cgi?id=294940
rdar://150067500

Reviewed by NOBODY (OOPS!).

EWS (merge-queue) searches for “unreviewed test gardening” in the entire commit message.
This was added to commit classes but it should actually be a hard requirement.
This PR makes it so test gardening commits are required to have “unreviewed test gardening”
in the commit message to be classified as such.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit_classifier.py:
(CommitClassifier.CommitClass.__init__): Check for contents.
(CommitClassifier.CommitClass.__repr__): Update repr with contents and trailers.
(CommitClassifier.classify): Content matching in a commit message should be a hard requirement.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/classify_unittest.py:
(TestClassify.test_path_no_repository):
(TestClassify):
(TestClassify.test_content_success):
(TestClassify.test_content_failure):
@briannafan briannafan self-assigned this Jun 25, 2025
@briannafan briannafan added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 25, 2025 •
edited
Loading

EWS run on current version of this PR (hash 247def1)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🧪 services ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facetothefate facetothefate Awaiting requested review from facetothefate facetothefate is a code owner

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@gsnedders gsnedders Awaiting requested review from gsnedders gsnedders is a code owner

Assignees

@briannafan briannafan

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briannafan @webkit-early-warning-system