Skip to content

Have btjs show file and line number information #47143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Have btjs show file and line number information #47143

merged 1 commit into from
Jun 25, 2025

Conversation

msaboff
Copy link
Contributor

@msaboff msaboff commented Jun 24, 2025 •
edited by webkit-early-warning-system
Loading

5a14597

Have btjs show file and line number information
https://bugs.webkit.org/show_bug.cgi?id=294936
rdar://58587955

Reviewed by Keith Miller.

Added file name, line number and column number to btjs frame output for JS functions.
Note that the line number and column will be wrong for minified JS source that is
pretty printed by the inspector.

* Source/JavaScriptCore/interpreter/CallFrame.cpp:
(JSC::CallFrame::dump const):

Canonical link: https://commits.webkit.org/296595@main

14babb7

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim   🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@msaboff msaboff requested a review from a team as a code owner June 24, 2025 22:46
@msaboff msaboff self-assigned this Jun 24, 2025
@msaboff msaboff added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 24, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on current version of this PR (hash 14babb7)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim   🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@msaboff msaboff added the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
@msaboff
Have btjs show file and line number information
5a14597 
https://bugs.webkit.org/show_bug.cgi?id=294936
rdar://58587955

Reviewed by Keith Miller.

Added file name, line number and column number to btjs frame output for JS functions.
Note that the line number and column will be wrong for minified JS source that is
pretty printed by the inspector.

* Source/JavaScriptCore/interpreter/CallFrame.cpp:
(JSC::CallFrame::dump const):

Canonical link: https://commits.webkit.org/296595@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Have-btjs-show-file-and-line-number-information branch from 14babb7 to 5a14597 Compare June 25, 2025 01:25
@webkit-commit-queue
Copy link
Collaborator

Committed 296595@main (5a14597): https://commits.webkit.org/296595@main

Reviewed commits have been landed. Closing PR #47143 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5a14597 into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
@msaboff msaboff deleted the eng/Have-btjs-show-file-and-line-number-information branch June 25, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmiller68 kmiller68 kmiller68 approved these changes

Assignees

@msaboff msaboff

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msaboff @webkit-early-warning-system @webkit-commit-queue @kmiller68