Using git-webkit pr via SSH dumps errors #47141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash a6bcf3a) |
emw-apple
approved these changes
Jun 25, 2025
There was a problem hiding this comment.
> git webkit pr --no-add --no-rebase
Total errors found: 0 in 1 files
Could not access credentials from keychain. Please run `security unlock-keychain` before continuing. (C/o/n/t/i/n/u/e):
So you need to change the options field to be a list, but otherwise looks good.
Comment on lines
33
to
38
| if Terminal.choose( | ||
| f'Could not access credentials from keychain. Please run `security unlock-keychain` before continuing.', | ||
| default='Continue', | ||
| options='Continue', | ||
| ) == 'Continue': | ||
| pass |
There was a problem hiding this comment.
I think I might prefer failing here, instead of prompting for continuation? Especially since the remedy is to run another terminal command.
There was a problem hiding this comment.
That makes a lot of sense, especially since this happens during ssh sessions where it's harder to just open a new terminal window!
a6bcf3a to
5700f62
Compare
|
EWS run on current version of this PR (hash 5700f62) |
rdar://151526906 https://bugs.webkit.org/show_bug.cgi?id=242647 Reviewed by Elliott Williams. Catch the KeyringError and return a helpful message that suggests running `security unlock-keychain`. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py: (handle_keyring_error): (credentials): Canonical link: https://commits.webkit.org/296626@main
5700f62 to
2cfc024
Compare
|
Committed 296626@main (2cfc024): https://commits.webkit.org/296626@main Reviewed commits have been landed. Closing PR #47141 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2cfc024
5700f62
🛠 wpe🛠 win🛠 ios-sim🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-cairo🧪 api-ios🧪 mac-wk2🛠 gtk🛠 vision🧪 gtk-wk2🛠 vision-sim🧪 mac-wk2-stress🧪 api-gtk🧪 mac-intel-wk2🛠 playstation🛠 tv🛠 tv-sim🛠 watch