git-webkit setup installs hooks in cwd repository #47139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash f7a6f97) |
JonWBedard
approved these changes
Jun 24, 2025
| match = repository.SSH_REMOTE.match(url) or repository.HTTP_REMOTE.match(url) | ||
| if match: | ||
| path = match.group('path') | ||
| if 'webkit' not in path.lower(): |
There was a problem hiding this comment.
You're going to match anything that's WebKit/<project> or <org>/WebKit. I'm approving this, although we should consider basing this off of a variable in metadata/git_config_extension instead, which would be more generic.
rdar://143774918 https://bugs.webkit.org/show_bug.cgi?id=293771 Reviewed by Jonathan Bedard. Check whether the repository the program is run in is under the WebKit Project. If not, warn the user that installing hooks may be undesirable. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py: (InstallHooks.main): * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py: (TestInstallHooks.test_security_levels): (TestInstallHooks.test_install_hook): (TestInstallHooks.test_install_hook_alternate_hook_path_change): (TestInstallHooks.test_install_hook_alternate_hook_path_use): (TestInstallHooks.test_install_hook_alternate_hook_path_exit): (TestInstallHooks.test_security_level_in_hook): Canonical link: https://commits.webkit.org/296586@main
f7a6f97 to
e6080b6
Compare
|
Committed 296586@main (e6080b6): https://commits.webkit.org/296586@main Reviewed commits have been landed. Closing PR #47139 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e6080b6
f7a6f97
🛠 win🧪 win-tests🧪 ios-wk2-wpt🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2