Skip to content

[SaferCPP] Improve smart pointer adoption in the UIProcess C API, part 1 #47137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

[SaferCPP] Improve smart pointer adoption in the UIProcess C API, part 1 #47137

merged 1 commit into from
Jun 25, 2025

Conversation

zakariaridouh
Copy link
Contributor

@zakariaridouh zakariaridouh commented Jun 24, 2025 •
edited by webkit-early-warning-system
Loading

15af0f5

[SaferCPP] Improve smart pointer adoption in the UIProcess C API, part 1
https://bugs.webkit.org/show_bug.cgi?id=294930
rdar://154229182

Reviewed by Charlie Wolfe.

Improve smart pointer adoption in the UIProcess C API to burn down the exposed C API failing files, fixing the following files:

        - Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp
        - Source/WebKit/UIProcess/API/C/WKFrameInfoRef.cpp
        - Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp
        - Source/WebKit/UIProcess/API/C/WKGeolocationManager.cpp
        - Source/WebKit/UIProcess/API/C/WKGeolocationPermissionRequest.cpp
        - Source/WebKit/UIProcess/API/C/WKHTTPCookieStoreRef.cpp
        - Source/WebKit/UIProcess/API/C/WKMediaKeySystemPermissionCallback.cpp
        - Source/WebKit/UIProcess/API/C/WKNotificationPermissionRequest.cpp
        - Source/WebKit/UIProcess/API/C/WKOpenPanelParametersRef.cpp

* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp:
(WKContextMenuListenerUseContextMenuItems):
* Source/WebKit/UIProcess/API/C/WKFrameInfoRef.cpp:
(WKFrameInfoCreateFrameHandleRef):
* Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp:
(WKFramePolicyListenerUse):
(WKFramePolicyListenerUseInNewProcess):
(useWithPolicies):
(WKFramePolicyListenerDownload):
(WKFramePolicyListenerIgnore):
* Source/WebKit/UIProcess/API/C/WKGeolocationManager.cpp:
(WKGeolocationManagerSetProvider):
(WKGeolocationManagerProviderDidChangePosition):
(WKGeolocationManagerProviderDidFailToDeterminePosition):
(WKGeolocationManagerProviderDidFailToDeterminePositionWithErrorMessage):
* Source/WebKit/UIProcess/API/C/WKGeolocationPermissionRequest.cpp:
(WKGeolocationPermissionRequestAllow):
(WKGeolocationPermissionRequestDeny):
* Source/WebKit/UIProcess/API/C/WKHTTPCookieStoreRef.cpp:
(WKHTTPCookieStoreDeleteAllCookies):
(WKHTTPCookieStoreSetHTTPCookieAcceptPolicy):
* Source/WebKit/UIProcess/API/C/WKMediaKeySystemPermissionCallback.cpp:
(WKMediaKeySystemPermissionCallbackComplete):
* Source/WebKit/UIProcess/API/C/WKNotificationPermissionRequest.cpp:
(WKNotificationPermissionRequestAllow):
(WKNotificationPermissionRequestDeny):
* Source/WebKit/UIProcess/API/C/WKOpenPanelParametersRef.cpp:
(WKOpenPanelParametersCopyAcceptedMIMETypes):
(WKOpenPanelParametersCopyAcceptedFileExtensions):
(WKOpenPanelParametersCopyAllowedMIMETypes):
(WKOpenPanelParametersCopySelectedFileNames):

Canonical link: https://commits.webkit.org/296592@main

2003115

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@zakariaridouh zakariaridouh requested a review from cdumez as a code owner June 24, 2025 21:30
@zakariaridouh zakariaridouh self-assigned this Jun 24, 2025
@zakariaridouh zakariaridouh added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 24, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 7cd50ba)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ⏳ 🛠 win
❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🛠 wpe-cairo
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🛠 gtk
❌ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
❌ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
⏳ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ⏳ 🛠 playstation
⏳ 🛠 tv ⏳ 🛠 mac-safer-cpp
⏳ 🛠 tv-sim
⏳ 🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 24, 2025
@zakariaridouh zakariaridouh removed the merging-blocked Applied to prevent a change from being merged label Jun 24, 2025
@zakariaridouh zakariaridouh force-pushed the eng/SaferCPP-Improve-smart-pointer-adoption-in-the-UIProcess-C-API-part-1 branch from 7cd50ba to 151d313 Compare June 24, 2025 21:44
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 151d313)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ⏳ 🛠 win
❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🛠 wpe-cairo
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🛠 gtk
❌ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
❌ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
⏳ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ❌ 🛠 playstation
❌ 🛠 tv ❌ 🛠 mac-safer-cpp
❌ 🛠 tv-sim
❌ 🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 24, 2025
@zakariaridouh zakariaridouh removed the merging-blocked Applied to prevent a change from being merged label Jun 24, 2025
@zakariaridouh zakariaridouh force-pushed the eng/SaferCPP-Improve-smart-pointer-adoption-in-the-UIProcess-C-API-part-1 branch from 151d313 to 2003115 Compare June 24, 2025 22:27
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on current version of this PR (hash 2003115)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@zakariaridouh zakariaridouh added the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
@zakariaridouh
[SaferCPP] Improve smart pointer adoption in the UIProcess C API, part 1
15af0f5 
https://bugs.webkit.org/show_bug.cgi?id=294930
rdar://154229182

Reviewed by Charlie Wolfe.

Improve smart pointer adoption in the UIProcess C API to burn down the exposed C API failing files, fixing the following files:

	- Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp
	- Source/WebKit/UIProcess/API/C/WKFrameInfoRef.cpp
	- Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp
	- Source/WebKit/UIProcess/API/C/WKGeolocationManager.cpp
	- Source/WebKit/UIProcess/API/C/WKGeolocationPermissionRequest.cpp
	- Source/WebKit/UIProcess/API/C/WKHTTPCookieStoreRef.cpp
	- Source/WebKit/UIProcess/API/C/WKMediaKeySystemPermissionCallback.cpp
	- Source/WebKit/UIProcess/API/C/WKNotificationPermissionRequest.cpp
	- Source/WebKit/UIProcess/API/C/WKOpenPanelParametersRef.cpp

* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp:
(WKContextMenuListenerUseContextMenuItems):
* Source/WebKit/UIProcess/API/C/WKFrameInfoRef.cpp:
(WKFrameInfoCreateFrameHandleRef):
* Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp:
(WKFramePolicyListenerUse):
(WKFramePolicyListenerUseInNewProcess):
(useWithPolicies):
(WKFramePolicyListenerDownload):
(WKFramePolicyListenerIgnore):
* Source/WebKit/UIProcess/API/C/WKGeolocationManager.cpp:
(WKGeolocationManagerSetProvider):
(WKGeolocationManagerProviderDidChangePosition):
(WKGeolocationManagerProviderDidFailToDeterminePosition):
(WKGeolocationManagerProviderDidFailToDeterminePositionWithErrorMessage):
* Source/WebKit/UIProcess/API/C/WKGeolocationPermissionRequest.cpp:
(WKGeolocationPermissionRequestAllow):
(WKGeolocationPermissionRequestDeny):
* Source/WebKit/UIProcess/API/C/WKHTTPCookieStoreRef.cpp:
(WKHTTPCookieStoreDeleteAllCookies):
(WKHTTPCookieStoreSetHTTPCookieAcceptPolicy):
* Source/WebKit/UIProcess/API/C/WKMediaKeySystemPermissionCallback.cpp:
(WKMediaKeySystemPermissionCallbackComplete):
* Source/WebKit/UIProcess/API/C/WKNotificationPermissionRequest.cpp:
(WKNotificationPermissionRequestAllow):
(WKNotificationPermissionRequestDeny):
* Source/WebKit/UIProcess/API/C/WKOpenPanelParametersRef.cpp:
(WKOpenPanelParametersCopyAcceptedMIMETypes):
(WKOpenPanelParametersCopyAcceptedFileExtensions):
(WKOpenPanelParametersCopyAllowedMIMETypes):
(WKOpenPanelParametersCopySelectedFileNames):

Canonical link: https://commits.webkit.org/296592@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/SaferCPP-Improve-smart-pointer-adoption-in-the-UIProcess-C-API-part-1 branch from 2003115 to 15af0f5 Compare June 25, 2025 00:55
@webkit-commit-queue
Copy link
Collaborator

Committed 296592@main (15af0f5): https://commits.webkit.org/296592@main

Reviewed commits have been landed. Closing PR #47137 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 15af0f5 into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliewolfe charliewolfe charliewolfe approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@zakariaridouh zakariaridouh

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zakariaridouh @webkit-early-warning-system @webkit-commit-queue @charliewolfe @webkit-ews-buildbot