Skip to content

Small protected getter cleanup after 296568@main #47135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zakariaridouh
Copy link
Contributor

@zakariaridouh zakariaridouh commented Jun 24, 2025

f110282

Small protected getter cleanup after 296568@main
https://bugs.webkit.org/show_bug.cgi?id=294929
rdar://154227236

Reviewed by Charlie Wolfe.

Small followup code cleanup to not introduce a new local variable
in `Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp` after 296568@main.

Fix it here.

* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::protectedRelatedPage const):
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
* Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp:
(WKPageConfigurationGetRelatedPage):

Canonical link: https://commits.webkit.org/296594@main

83ef998

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@zakariaridouh zakariaridouh requested a review from cdumez as a code owner June 24, 2025 21:08
@zakariaridouh zakariaridouh self-assigned this Jun 24, 2025
@zakariaridouh zakariaridouh added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 24, 2025
@zakariaridouh zakariaridouh added the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Small-protected-getter-cleanup-after-296568-main branch from 83ef998 to d468cc9 Compare June 25, 2025 01:07
https://bugs.webkit.org/show_bug.cgi?id=294929
rdar://154227236

Reviewed by Charlie Wolfe.

Small followup code cleanup to not introduce a new local variable
in `Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp` after 296568@main.

Fix it here.

* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::protectedRelatedPage const):
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
* Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp:
(WKPageConfigurationGetRelatedPage):

Canonical link: https://commits.webkit.org/296594@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Small-protected-getter-cleanup-after-296568-main branch from d468cc9 to f110282 Compare June 25, 2025 01:09
@webkit-commit-queue
Copy link
Collaborator

Committed 296594@main (f110282): https://commits.webkit.org/296594@main

Reviewed commits have been landed. Closing PR #47135 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f110282 into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants