Skip to content

Test Gardening: Increase fuzziness for svg/zoom/page/text-with-non-scaling-stroke.html #47133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Test Gardening: Increase fuzziness for svg/zoom/page/text-with-non-scaling-stroke.html #47133

merged 1 commit into from
Jun 25, 2025

Conversation

fantasai
Copy link
Contributor

@fantasai fantasai commented Jun 24, 2025 •
edited by webkit-early-warning-system
Loading

c846dfd

Test Gardening: Increase fuzziness for svg/zoom/page/text-with-non-scaling-stroke.html
https://bugs.webkit.org/show_bug.cgi?id=294087
rdar://152673707

Reviewed by Jonathan Bedard.

Increase allowed fuzziness from 45 to 50 pixels for a text rendering test,
so that it passes more reliably.

* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/svg/zoom/page/text-with-non-scaling-stroke.html:

Canonical link: https://commits.webkit.org/296636@main

3f175de

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@fantasai fantasai self-assigned this Jun 24, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on previous version of this PR (hash ece805f)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ⏳ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
⏳ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2 ⏳ 🛠 playstation
✅ 🛠 tv ⏳ 🛠 mac-safer-cpp
⏳ 🛠 tv-sim
⏳ 🛠 watch
✅ 🛠 watch-sim

@fantasai fantasai force-pushed the eng/macOS-wk2-svg-zoom-page-text-with-non-scaling-stroke-html-is-constant-failure-in-image-diff branch from ece805f to 3f175de Compare June 24, 2025 20:31
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on current version of this PR (hash 3f175de)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@fantasai fantasai changed the title Increase fuzziness for vg/zoom/page/text-with-non-scaling-stroke.html Test Gardening: Increase fuzziness for svg/zoom/page/text-with-non-scaling-stroke.html Jun 24, 2025
@JonWBedard JonWBedard added the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
@fantasai @JonWBedard
Test Gardening: Increase fuzziness for svg/zoom/page/text-with-non-sc…
c846dfd 
…aling-stroke.html

https://bugs.webkit.org/show_bug.cgi?id=294087
rdar://152673707

Reviewed by Jonathan Bedard.

Increase allowed fuzziness from 45 to 50 pixels for a text rendering test,
so that it passes more reliably.

* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/svg/zoom/page/text-with-non-scaling-stroke.html:

Canonical link: https://commits.webkit.org/296636@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/macOS-wk2-svg-zoom-page-text-with-non-scaling-stroke-html-is-constant-failure-in-image-diff branch from 3f175de to c846dfd Compare June 25, 2025 22:04
@webkit-commit-queue
Copy link
Collaborator

Committed 296636@main (c846dfd): https://commits.webkit.org/296636@main

Reviewed commits have been landed. Closing PR #47133 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c846dfd into WebKit:main Jun 25, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonWBedard JonWBedard JonWBedard approved these changes

Assignees

@fantasai fantasai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fantasai @webkit-early-warning-system @webkit-commit-queue @JonWBedard