Skip to content

Popover background is not transparent in light mode. #47127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Popover background is not transparent in light mode. #47127

merged 1 commit into from
Jun 24, 2025

Conversation

xeenon
Copy link
Contributor

@xeenon xeenon commented Jun 24, 2025 •
edited by webkit-early-warning-system
Loading

4df51ee

Popover background is not transparent in light mode.
https://webkit.org/b/294919
rdar://problem/154214340

Reviewed by Brian Weinstein.

Safari disables _drawsBackground only when in dark mode. To ensure consistent behavior for extensions
regardless of the current appearance, we should default this to NO for popup and sidebar web views.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::webViewConfiguration):

Canonical link: https://commits.webkit.org/296578@main

744ea3f

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@xeenon xeenon requested a review from b-weinstein as a code owner June 24, 2025 18:35
@xeenon xeenon self-assigned this Jun 24, 2025
@xeenon xeenon added the WebKit Extensions Bugs related to extension support. label Jun 24, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on current version of this PR (hash 744ea3f)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@elijahsawyers elijahsawyers self-requested a review June 24, 2025 18:41
@xeenon xeenon added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
@xeenon
Popover background is not transparent in light mode.
4df51ee 
https://webkit.org/b/294919
rdar://problem/154214340

Reviewed by Brian Weinstein.

Safari disables _drawsBackground only when in dark mode. To ensure consistent behavior for extensions
regardless of the current appearance, we should default this to NO for popup and sidebar web views.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::webViewConfiguration):

Canonical link: https://commits.webkit.org/296578@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296578@main (4df51ee): https://commits.webkit.org/296578@main

Reviewed commits have been landed. Closing PR #47127 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4df51ee into WebKit:main Jun 24, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
@xeenon xeenon deleted the bug/294919 branch June 24, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elijahsawyers elijahsawyers elijahsawyers approved these changes

@b-weinstein b-weinstein b-weinstein approved these changes

Assignees

@xeenon xeenon

Labels
WebKit Extensions Bugs related to extension support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xeenon @webkit-early-warning-system @webkit-commit-queue @elijahsawyers @b-weinstein