Web Inspector: Replace MessageSource::AppCache in WebCore #47122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash e1b61af) |
dcrousso
approved these changes
Jun 25, 2025
| @@ -144,7 +144,6 @@ extern NSString *WebConsoleMessageJSMessageSource; | |||
| extern NSString *WebConsoleMessageNetworkMessageSource; | |||
| extern NSString *WebConsoleMessageConsoleAPIMessageSource; | |||
| extern NSString *WebConsoleMessageStorageMessageSource; | |||
| extern NSString *WebConsoleMessageAppCacheMessageSource; | |||
There was a problem hiding this comment.
we may need to keep this if there's a client elsewhere at Apple that still uses it
There was a problem hiding this comment.
I hesitated making changes under Source/WebKitLegacy/.
@cdumez, do we still touch that or should I leave it unchanged in this patch?
There was a problem hiding this comment.
we may need to keep this if there's a client elsewhere at Apple that still uses it
Nobody seems to be using this anymore.
If they somehow are and hit a crash, it will be a good way to identify themselves by filing a bug so we can ask them to migrate (or revert this change if needed).
https://bugs.webkit.org/show_bug.cgi?id=294907 rdar://154202768 Reviewed by Devin Rousso. ApplicationCache (aka AppCache) is a deprecated feature: https://bugs.webkit.org/show_bug.cgi?id=181764 Support for inspecting AppCache was removed from WebInspector: https://commits.webkit.org/289820@main With the feature is still technically available in WebCore, it can emit some console messages on an AppCache-specific message channel. WebInspector frontend doesn't explicitly handle them anymore. This patch replaces the `MessageSource::AppCache` with `MessageSource::Other` to ensure that any potential messages still get handled. * Source/JavaScriptCore/inspector/ConsoleMessage.cpp: (Inspector::messageSourceValue): * Source/JavaScriptCore/inspector/protocol/Console.json: * Source/JavaScriptCore/runtime/ConsoleClient.cpp: (JSC::appendMessagePrefix): * Source/JavaScriptCore/runtime/ConsoleTypes.h: * Source/WebCore/inspector/agents/page/PageConsoleAgent.cpp: (WebCore::PageConsoleAgent::getLoggingChannels): * Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::abort): (WebCore::ApplicationCacheGroup::didFinishLoadingEntry): (WebCore::ApplicationCacheGroup::didFailLoadingEntry): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::didFailLoadingManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): * Source/WebKit/Shared/JavaScriptCore.serialization.in: * Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm: (stringForMessageSource): * Source/WebKitLegacy/mac/WebKit.exp: * Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h: Canonical link: https://commits.webkit.org/296659@main
e1b61af to
b3fe8b7
Compare
|
Committed 296659@main (b3fe8b7): https://commits.webkit.org/296659@main Reviewed commits have been landed. Closing PR #47122 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b3fe8b7
e1b61af