Skip to content

Unreviewed, fix downlevel macOS builds after upstreaming Script Telemetry code #47118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Unreviewed, fix downlevel macOS builds after upstreaming Script Telemetry code #47118

merged 1 commit into from
Jun 24, 2025
+17 −0

Conversation

whsieh
Copy link
Member

@whsieh whsieh commented Jun 24, 2025 •
edited by webkit-early-warning-system
Loading

6752f49

Unreviewed, fix downlevel macOS builds after upstreaming Script Telemetry code
rdar://154192799

Bring back WebPrivacy forward declarations that I tried to remove while upstreaming code from
WebKitAdditions in 296540@main.

* Source/WebCore/PAL/pal/spi/cocoa/WebPrivacySPI.h:

Canonical link: https://commits.webkit.org/296561@main

d830ab3

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@whsieh whsieh self-assigned this Jun 24, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on current version of this PR (hash d830ab3)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2   🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@whsieh whsieh added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
@whsieh
Unreviewed, fix downlevel macOS builds after upstreaming Script Telem…
6752f49 
…etry code

rdar://154192799

Bring back WebPrivacy forward declarations that I tried to remove while upstreaming code from
WebKitAdditions in 296540@main.

* Source/WebCore/PAL/pal/spi/cocoa/WebPrivacySPI.h:

Canonical link: https://commits.webkit.org/296561@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296561@main (6752f49): https://commits.webkit.org/296561@main

Reviewed commits have been landed. Closing PR #47118 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6752f49 into WebKit:main Jun 24, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@whsieh whsieh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whsieh @webkit-early-warning-system @webkit-commit-queue