Skip to content

Address assorted smart pointer warnings in Source/WebKit #47114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Address assorted smart pointer warnings in Source/WebKit #47114

merged 1 commit into from
Jun 24, 2025
+30 −39

Conversation

annevk
Copy link
Contributor

@annevk annevk commented Jun 24, 2025 •
edited by webkit-early-warning-system
Loading

ddfd739

Address assorted smart pointer warnings in Source/WebKit
https://bugs.webkit.org/show_bug.cgi?id=294899

Reviewed by Chris Dumez.

Apply https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines and
notably in RemoteScrollingCoordinatorProxyMac and
RTCDataChannelRemoteManager we change a member variable from RefPtr to
Ref and make it const.

Canonical link: https://commits.webkit.org/296576@main

654a545

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk self-assigned this Jun 24, 2025
@annevk annevk added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jun 24, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 76fc7cd)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot
Copy link
Collaborator

Safer C++ Build #41384 (76fc7cd)

⚠️ Found 6 fixed files! Please update expectations in Source/[Project]/SaferCPPExpectations by running the following command and update your pull request:

  • Tools/Scripts/update-safer-cpp-expectations -p WebKit --UncheckedCallArgsChecker UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm UIProcess/ProvisionalPageProxy.cpp --UncheckedLocalVarsChecker UIProcess/mac/WKTextAnimationManagerMac.mm --UncountedCallArgsChecker UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm UIProcess/ProvisionalPageProxy.cpp --UnretainedLocalVarsChecker Shared/cf/CoreIPCCFArray.mm UIProcess/mac/WKTextAnimationManagerMac.mm

@annevk annevk marked this pull request as ready for review June 24, 2025 13:37
@annevk annevk requested a review from cdumez as a code owner June 24, 2025 13:37
@annevk annevk force-pushed the eng/Address-assorted-smart-pointer-warnings-in-Source-WebKit branch from 76fc7cd to 654a545 Compare June 24, 2025 15:50
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on current version of this PR (hash 654a545)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@annevk annevk added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jun 24, 2025
@annevk
Address assorted smart pointer warnings in Source/WebKit
ddfd739 
https://bugs.webkit.org/show_bug.cgi?id=294899

Reviewed by Chris Dumez.

Apply https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines and
notably in RemoteScrollingCoordinatorProxyMac and
RTCDataChannelRemoteManager we change a member variable from RefPtr to
Ref and make it const.

Canonical link: https://commits.webkit.org/296576@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Address-assorted-smart-pointer-warnings-in-Source-WebKit branch from 654a545 to ddfd739 Compare June 24, 2025 17:48
@webkit-commit-queue
Copy link
Collaborator

Committed 296576@main (ddfd739): https://commits.webkit.org/296576@main

Reviewed commits have been landed. Closing PR #47114 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ddfd739 into WebKit:main Jun 24, 2025
@webkit-commit-queue webkit-commit-queue removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jun 24, 2025
@annevk annevk deleted the eng/Address-assorted-smart-pointer-warnings-in-Source-WebKit branch June 24, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@annevk annevk

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@annevk @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @cdumez