Skip to content

Re-import html/rendering/the-details-element WPT #47108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Re-import html/rendering/the-details-element WPT #47108

merged 1 commit into from
Jun 24, 2025
+29 −16

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Jun 24, 2025 •
edited by webkit-early-warning-system
Loading

8c760a0

Re-import html/rendering/the-details-element WPT
https://bugs.webkit.org/show_bug.cgi?id=294892
rdar://154165662

Reviewed by Anne van Kesteren.

Upstream commit: web-platform-tests/wpt@bdbb910

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/auto-expand-details-text-fragment-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/auto-expand-details-text-fragment.html:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/resources/auto-expand-details-text-fragment.html:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/w3c-import.log:

Canonical link: https://commits.webkit.org/296570@main

23a94a6

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m self-assigned this Jun 24, 2025
@nt1m nt1m added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 24, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on current version of this PR (hash 23a94a6)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested a review from annevk June 24, 2025 07:18
@nt1m nt1m added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 24, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 24, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Failed ios-wk2 checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #47108 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 24, 2025
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #61265.

@nt1m nt1m added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jun 24, 2025
@nt1m
Re-import html/rendering/the-details-element WPT
8c760a0 
https://bugs.webkit.org/show_bug.cgi?id=294892
rdar://154165662

Reviewed by Anne van Kesteren.

Upstream commit: web-platform-tests/wpt@bdbb910

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/auto-expand-details-text-fragment-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/auto-expand-details-text-fragment.html:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/resources/auto-expand-details-text-fragment.html:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-details-element/w3c-import.log:

Canonical link: https://commits.webkit.org/296570@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Re-import-html-rendering-the-details-element-WPT branch from 23a94a6 to 8c760a0 Compare June 24, 2025 16:31
@webkit-commit-queue
Copy link
Collaborator

Committed 296570@main (8c760a0): https://commits.webkit.org/296570@main

Reviewed commits have been landed. Closing PR #47108 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8c760a0 into WebKit:main Jun 24, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees

@nt1m nt1m

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nt1m @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @annevk