Skip to content

Reduce scope of WTF_ALLOW_UNSAFE_BUFFER_USAGE in ImmutableStyleProperties #47101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Reduce scope of WTF_ALLOW_UNSAFE_BUFFER_USAGE in ImmutableStyleProperties #47101

merged 1 commit into from
Jun 24, 2025

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Jun 24, 2025 •
edited by webkit-early-warning-system
Loading

d6dcfd4

Reduce scope of WTF_ALLOW_UNSAFE_BUFFER_USAGE in ImmutableStyleProperties
https://bugs.webkit.org/show_bug.cgi?id=294884

Reviewed by Anne van Kesteren.

This tested as performance neutral on Speedometer.

* Source/WebCore/css/ImmutableStyleProperties.cpp:
(WebCore::ImmutableStyleProperties::ImmutableStyleProperties):
(WebCore::ImmutableStyleProperties::~ImmutableStyleProperties):
(WebCore::ImmutableStyleProperties::findPropertyIndex const):
(WebCore::ImmutableStyleProperties::findCustomPropertyIndex const):
* Source/WebCore/css/ImmutableStyleProperties.h:
(WebCore::ImmutableStyleProperties::valueSpan const):
(WebCore::ImmutableStyleProperties::metadataSpan const):
(WebCore::ImmutableStyleProperties::propertyAt const):
(WebCore::ImmutableStyleProperties::objectSize):
(WebCore::ImmutableStyleProperties::valueArray const): Deleted.
(WebCore::ImmutableStyleProperties::metadataArray const): Deleted.

Canonical link: https://commits.webkit.org/296564@main

3ed82d6

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Jun 24, 2025
@cdumez cdumez added the CSS Cascading Style Sheets implementation label Jun 24, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 24, 2025 •
edited
Loading

EWS run on current version of this PR (hash 3ed82d6)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
@cdumez
Reduce scope of WTF_ALLOW_UNSAFE_BUFFER_USAGE in ImmutableStyleProper…
d6dcfd4 
…ties

https://bugs.webkit.org/show_bug.cgi?id=294884

Reviewed by Anne van Kesteren.

This tested as performance neutral on Speedometer.

* Source/WebCore/css/ImmutableStyleProperties.cpp:
(WebCore::ImmutableStyleProperties::ImmutableStyleProperties):
(WebCore::ImmutableStyleProperties::~ImmutableStyleProperties):
(WebCore::ImmutableStyleProperties::findPropertyIndex const):
(WebCore::ImmutableStyleProperties::findCustomPropertyIndex const):
* Source/WebCore/css/ImmutableStyleProperties.h:
(WebCore::ImmutableStyleProperties::valueSpan const):
(WebCore::ImmutableStyleProperties::metadataSpan const):
(WebCore::ImmutableStyleProperties::propertyAt const):
(WebCore::ImmutableStyleProperties::objectSize):
(WebCore::ImmutableStyleProperties::valueArray const): Deleted.
(WebCore::ImmutableStyleProperties::metadataArray const): Deleted.

Canonical link: https://commits.webkit.org/296564@main
@webkit-commit-queue webkit-commit-queue force-pushed the 294884_ImmutableStyleProperties_safe_buffers branch from 3ed82d6 to d6dcfd4 Compare June 24, 2025 15:15
@webkit-commit-queue
Copy link
Collaborator

Committed 296564@main (d6dcfd4): https://commits.webkit.org/296564@main

Reviewed commits have been landed. Closing PR #47101 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d6dcfd4 into WebKit:main Jun 24, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees

@cdumez cdumez

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @annevk