[Style] Remove more duplicated code by sharing conversion code for all Style::LengthWrapperBase subclasses #47097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
06b502a to
a89c17e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
a89c17e to
8121876
Compare
|
EWS run on previous version of this PR (hash 8121876) |
This comment was marked as outdated.
This comment was marked as outdated.
8121876 to
9bf5e85
Compare
|
EWS run on current version of this PR (hash 9bf5e85) |
darinadler
approved these changes
Jun 24, 2025
…l Style::LengthWrapperBase subclasses https://bugs.webkit.org/show_bug.cgi?id=294879 Reviewed by Darin Adler. Replace type specific CSSValueConversion specialization for with Style::LengthWrapperBase subclasses with a single generic implementation that checks for supported flag values. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/rendering/RenderTheme.cpp: * Source/WebCore/style/StyleBuilderConverter.h: * Source/WebCore/style/values/box/StyleMargin.cpp: Removed. * Source/WebCore/style/values/box/StyleMargin.h: * Source/WebCore/style/values/box/StylePadding.cpp: Removed. * Source/WebCore/style/values/box/StylePadding.h: * Source/WebCore/style/values/flexbox/StyleFlexBasis.cpp: * Source/WebCore/style/values/flexbox/StyleFlexBasis.h: * Source/WebCore/style/values/motion/StyleOffsetDistance.cpp: Removed. * Source/WebCore/style/values/motion/StyleOffsetDistance.h: * Source/WebCore/style/values/position/StyleInset.cpp: Removed. * Source/WebCore/style/values/position/StyleInset.h: * Source/WebCore/style/values/primitives/StyleLengthWrapper+CSSValueConversion.h: Added. * Source/WebCore/style/values/scroll-snap/StyleScrollPadding.cpp: * Source/WebCore/style/values/scroll-snap/StyleScrollPadding.h: * Source/WebCore/style/values/sizing/StyleMaximumSize.cpp: Removed. * Source/WebCore/style/values/sizing/StyleMaximumSize.h: * Source/WebCore/style/values/sizing/StyleMinimumSize.cpp: Removed. * Source/WebCore/style/values/sizing/StyleMinimumSize.h: * Source/WebCore/style/values/sizing/StylePreferredSize.cpp: * Source/WebCore/style/values/sizing/StylePreferredSize.h: * Source/WebCore/style/values/svg/StyleSVGPaint.cpp: Canonical link: https://commits.webkit.org/296572@main
9bf5e85 to
e8c43a9
Compare
|
Committed 296572@main (e8c43a9): https://commits.webkit.org/296572@main Reviewed commits have been landed. Closing PR #47097 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e8c43a9
9bf5e85
🧪 wpe-wk2🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2