Skip to content

[SaferCPP] Fix smart pointer issues in WKProtectionSpace.cpp #47091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

[SaferCPP] Fix smart pointer issues in WKProtectionSpace.cpp #47091

merged 1 commit into from
Jun 24, 2025
+8 −9

Conversation

zakariaridouh
Copy link
Contributor

@zakariaridouh zakariaridouh commented Jun 23, 2025 •
edited by webkit-early-warning-system
Loading

2bbfd60

[SaferCPP] Fix smart pointer issues in WKProtectionSpace.cpp
https://bugs.webkit.org/show_bug.cgi?id=294874
rdar://154137544

Reviewed by Chris Dumez.

Fix smart pointer issues in WKProtectionSpace.cpp

* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/UIProcess/API/C/WKProtectionSpace.cpp:
(WKProtectionSpaceCopyHost):
(WKProtectionSpaceGetPort):
(WKProtectionSpaceCopyRealm):
(WKProtectionSpaceGetIsProxy):
(WKProtectionSpaceGetServerType):
(WKProtectionSpaceGetReceivesCredentialSecurely):
(WKProtectionSpaceGetAuthenticationScheme):

Canonical link: https://commits.webkit.org/296547@main

6216e2f

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@zakariaridouh zakariaridouh requested a review from cdumez as a code owner June 23, 2025 23:43
@zakariaridouh zakariaridouh self-assigned this Jun 23, 2025
@zakariaridouh zakariaridouh added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 23, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 23, 2025 •
edited
Loading

EWS run on current version of this PR (hash 6216e2f)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

cdumez
cdumez approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can do slightly larger patches for Safer CPP?

@zakariaridouh zakariaridouh added the merge-queue Applied to send a pull request to merge-queue label Jun 24, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the eng/SaferCPP-Fix-smart-pointer-issues-in-WKProtectionSpace-cpp branch from 6216e2f to b2f3b85 Compare June 24, 2025 03:32
@zakariaridouh
[SaferCPP] Fix smart pointer issues in WKProtectionSpace.cpp
2bbfd60 
https://bugs.webkit.org/show_bug.cgi?id=294874
rdar://154137544

Reviewed by Chris Dumez.

Fix smart pointer issues in WKProtectionSpace.cpp

* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/UIProcess/API/C/WKProtectionSpace.cpp:
(WKProtectionSpaceCopyHost):
(WKProtectionSpaceGetPort):
(WKProtectionSpaceCopyRealm):
(WKProtectionSpaceGetIsProxy):
(WKProtectionSpaceGetServerType):
(WKProtectionSpaceGetReceivesCredentialSecurely):
(WKProtectionSpaceGetAuthenticationScheme):

Canonical link: https://commits.webkit.org/296547@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/SaferCPP-Fix-smart-pointer-issues-in-WKProtectionSpace-cpp branch from b2f3b85 to 2bbfd60 Compare June 24, 2025 03:33
@webkit-commit-queue
Copy link
Collaborator

Committed 296547@main (2bbfd60): https://commits.webkit.org/296547@main

Reviewed commits have been landed. Closing PR #47091 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2bbfd60 into WebKit:main Jun 24, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 24, 2025
@zakariaridouh zakariaridouh deleted the eng/SaferCPP-Fix-smart-pointer-issues-in-WKProtectionSpace-cpp branch June 24, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@zakariaridouh zakariaridouh

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zakariaridouh @webkit-early-warning-system @webkit-commit-queue @cdumez