Skip to content

[macOS] Interaction region debug overlay is incorrect for elements with non-uniform border radii #47088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

[macOS] Interaction region debug overlay is incorrect for elements with non-uniform border radii #47088

merged 1 commit into from
Jun 24, 2025

Conversation

lilyspiniolas
Copy link
Contributor

@lilyspiniolas lilyspiniolas commented Jun 23, 2025 •
edited by webkit-early-warning-system
Loading

9811652

[macOS] Interaction region debug overlay is incorrect for elements with non-uniform border radii
https://bugs.webkit.org/show_bug.cgi?id=294869
rdar://154136045

Reviewed by Abrar Rahman Protyasha, Tim Horton, and Wenson Hsieh.

If the interaction region already has a calculated clip path (true for elements
with non-uniform border radii), then use it instead of calculating an incorrect one.
The path is transformed if needed to match the interaction region's onscreen position.

* Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::InteractionRegionOverlay::drawRect):

Canonical link: https://commits.webkit.org/296545@main

5bd490b

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@lilyspiniolas lilyspiniolas requested a review from cdumez as a code owner June 23, 2025 23:27
@lilyspiniolas lilyspiniolas self-assigned this Jun 23, 2025
@lilyspiniolas lilyspiniolas added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 23, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 23, 2025 •
edited
Loading

EWS run on current version of this PR (hash 5bd490b)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
❌ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

hortont424
hortont424 approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@hortont424 hortont424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it! Sorry for sending you down a rabbit hole.

@lilyspiniolas
Copy link
Contributor Author

Thank you for fixing it! Sorry for sending you down a rabbit hole.

no worries! 😄

@lilyspiniolas lilyspiniolas added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
@lilyspiniolas
[macOS] Interaction region debug overlay is incorrect for elements wi…
9811652 
…th non-uniform border radii

https://bugs.webkit.org/show_bug.cgi?id=294869
rdar://154136045

Reviewed by Abrar Rahman Protyasha, Tim Horton, and Wenson Hsieh.

If the interaction region already has a calculated clip path (true for elements
with non-uniform border radii), then use it instead of calculating an incorrect one.
The path is transformed if needed to match the interaction region's onscreen position.

* Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::InteractionRegionOverlay::drawRect):

Canonical link: https://commits.webkit.org/296545@main
@webkit-commit-queue
Copy link
Collaborator

Committed 296545@main (9811652): https://commits.webkit.org/296545@main

Reviewed commits have been landed. Closing PR #47088 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9811652 into WebKit:main Jun 24, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@whsieh whsieh whsieh approved these changes

@aprotyas aprotyas aprotyas approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@etiennesegonzac etiennesegonzac Awaiting requested review from etiennesegonzac

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

@rr-codes rr-codes Awaiting requested review from rr-codes

@megangardner megangardner Awaiting requested review from megangardner

@jesxilin jesxilin Awaiting requested review from jesxilin

Assignees

@lilyspiniolas lilyspiniolas

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lilyspiniolas @webkit-early-warning-system @webkit-commit-queue @hortont424 @whsieh @aprotyas